Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for #13683 #6944

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Companion for #13683 #6944

merged 4 commits into from
Mar 24, 2023

Conversation

davxy
Copy link
Member

@davxy davxy commented Mar 23, 2023 •
edited
Loading

Companion for paritytech/substrate#13683

cumulus companion: paritytech/cumulus#2371

  • trivial renaming of 'AppKey' to 'AppCrypto'
  • Prefer infallible explicit keystore calls over fallible generic sign_with

@davxy davxy mentioned this pull request Mar 23, 2023
Merged
@davxy davxy requested review from skunert and a team March 23, 2023 14:45
@davxy davxy self-assigned this Mar 23, 2023
@davxy davxy added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Mar 23, 2023
@paritytech paritytech deleted a comment from paritytech-cicd-pr Mar 23, 2023
@davxy davxy requested a review from koute March 23, 2023 15:29
koute
koute approved these changes Mar 24, 2023
View reviewed changes
node/primitives/src/disputes/mod.rs Outdated Show resolved Hide resolved
@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Head SHA changed from 8c2aba5 to ed552a2

@davxy
Copy link
Member Author

davxy commented Mar 24, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 27ddd27 into master Mar 24, 2023
@paritytech-processbot paritytech-processbot bot deleted the davxy-companion-for-13683 branch March 24, 2023 14:43
ordian added a commit that referenced this pull request Mar 27, 2023
@ordian
Merge branch 'master' into ao-malus-dont-panic
736ec15 
* master:
  bump timestamp script to v0.2 (#6954)
  Subsystem channel tweaks (#6905)
  Companion for #13683 (#6944)
ordian added a commit that referenced this pull request Mar 29, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-client
176c7b2 
* master:
  bump timestamp script to v0.2 (#6954)
  Subsystem channel tweaks (#6905)
  Companion for #13683 (#6944)
  inherent disputes: remove per block initializer and disputes timeout event (#6937)
ordian added a commit that referenced this pull request Mar 29, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-runtime
2ba635b 
* master:
  Companion: wasm-builder support stable Rust (#6967)
  Fix feature (#6966)
  configuration: backport async backing parameters from the feature branch (#6961)
  Histogram support in runtime metrics (#6935)
  Bump openssl from 0.10.38 to 0.10.48 (#6955)
  Proxy for Nomination Pools (#6846)
  Nomination Pools migration v5: RewardPool fix (#6957)
  bump timestamp script to v0.2 (#6954)
  Subsystem channel tweaks (#6905)
  Companion for #13683 (#6944)
  inherent disputes: remove per block initializer and disputes timeout event (#6937)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@koute koute koute approved these changes

@skunert skunert skunert approved these changes

Assignees

@davxy davxy

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davxy @koute @skunert