This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
PVF: instantiate runtime from bytes #7270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcnski
added
A0-please_review
s0me0ne-unkn0wn
approved these changes
May 23, 2023
There was a problem hiding this comment.
Looks very good! The only nit is naming: although the transition from artifact_path to artifact_bytes seems natural, we're usually using another naming for binary blobs, such as code, blob, code_blob, and similar. I'd use something like native_blob or I don't know. artifact_bytes says nothing about what's inside, I mean, that's a native executable code, not just bytes. So consider improving naming here, but that's not a blocker at all.
eskimor
approved these changes
May 23, 2023
|
@s0me0ne-unkn0wn |
Maybe 🤔 Or |
|
bot merge |
paritytech-processbot
bot
deleted the
mrcnski/instantiate-runtime-from-bytes
branch
ordian
added a commit
that referenced
this pull request
May 24, 2023
* master: PVF: instantiate runtime from bytes (#7270)
ordian
added a commit
that referenced
this pull request
May 25, 2023
…slashing-client * ao-past-session-slashing-runtime: XCM: Tools for uniquely referencing messages (#7234) Companion: Substrate#13869 (#7119) Companion for Substrate#14214 (#7283) Fix flaky test and error reporting (#7282) impl guide: Update Collator Generation (#7250) Add staking-miner bin (#7273) metrics: tests: Fix flaky runtime_can_publish_metrics (#7279) [companion] Fix request-response protocols backpressure mechanism (#7276) PVF: instantiate runtime from bytes (#7270)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
Summary of rationale:
create_runtime_from_artifact.Related
Closes #7266
paritytech/substrate#13861