This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
metrics: tests: Fix flaky runtime_can_publish_metrics #7279
+20
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an re-org happens wait_for_blocks(2) would actually exit after the second import of blocks 1, so the conditions for the metric to exist won't be met hence the occasional test failure. More details in: paritytech#7267 Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
alexggh
added
A0-please_review
bkchr
reviewed
May 24, 2023
node/test/service/src/lib.rs
Outdated
Comment on lines
345
to
353
| Box::pin(async move { | ||
| while let Some(notification) = import_notification_stream.next().await { | ||
| blocks.insert(notification.hash); | ||
| if blocks.len() == count { | ||
| break | ||
| } | ||
| } | ||
| }) | ||
| .await; |
There was a problem hiding this comment.
Suggested change
| Box::pin(async move { | |
| while let Some(notification) = import_notification_stream.next().await { | |
| blocks.insert(notification.hash); | |
| if blocks.len() == count { | |
| break | |
| } | |
| } | |
| }) | |
| .await; | |
| while let Some(notification) = import_notification_stream.next().await { | |
| blocks.insert(notification.hash); | |
| if blocks.len() == count { | |
| break | |
| } | |
| } |
bkchr
approved these changes
May 24, 2023
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
sandreim
approved these changes
May 24, 2023
|
bot merge |
ordian
added a commit
that referenced
this pull request
May 25, 2023
* master: XCM: Tools for uniquely referencing messages (#7234) Companion: Substrate#13869 (#7119) Companion for Substrate#14214 (#7283) Fix flaky test and error reporting (#7282) impl guide: Update Collator Generation (#7250) Add staking-miner bin (#7273) metrics: tests: Fix flaky runtime_can_publish_metrics (#7279)
ordian
added a commit
that referenced
this pull request
May 25, 2023
…slashing-client * ao-past-session-slashing-runtime: XCM: Tools for uniquely referencing messages (#7234) Companion: Substrate#13869 (#7119) Companion for Substrate#14214 (#7283) Fix flaky test and error reporting (#7282) impl guide: Update Collator Generation (#7250) Add staking-miner bin (#7273) metrics: tests: Fix flaky runtime_can_publish_metrics (#7279) [companion] Fix request-response protocols backpressure mechanism (#7276) PVF: instantiate runtime from bytes (#7270)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an re-org happens wait_for_blocks(2) would actually exit after the second import of blocks 1, so the conditions for the metric to exist won't be met hence the occasional test failure.
Fix that by adding a new methods which wait for blocks to be finalised, this should guarantee us that the preconditions for running the test are met.
More details in:
#7267