Add a "tracing visitor" to make it easier to find decode issues #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation for this is in making it easier to understand what went wrong when we try to decode historic blocks ie via https://github.com/jsdw/polkadot-historic-decoding-example.
This visitor is similar to the normal Value visitor, except that it tracks various information while decoding a value, and as such is able to print out a useful error in the event that it fails to decode, ie something like:
The
Value
to_string implementation was reworked in the process in order to allow Values to be printed in a non-compact form, so nowprint!("{value:#}")
will print a multiline form andprint!("{value}")
will continue to print a compact format. The ability to print context and custom format things was also added but is currently not exposed in the APIs; we can figure out what they should look like as a separate PR.