Consistify custom formatting with custom parsing and expose in the public API #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkhry
approved these changes
Aug 5, 2024
src/string_impls/to_string.rs
Outdated
| /// bar: true | ||
| /// }"#); | ||
| /// ``` | ||
| pub fn spaced(mut self) -> Self { |
There was a problem hiding this comment.
Mmm spaced isn't the best word for this is it! I was also thinking pretty to align with eg serde_json's use of the word!
There was a problem hiding this comment.
Changed to pretty; thanks for pointing this out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes two new functions for formatting values,
crate::stringify::to_writerandcrate::stringify::to_writer_custom(to align with the already presentcrate::stringify::from_str_custom), and also exposes a newcrate::stringiy::custom_formatterscontaining a formatter for displaying things as hex.to_writer_customexposes aToWriterBuilder. This provides options for customising the output of a value, such as a compact mode or a spaced mode for pretty printing values, and options to configure the indentation of spaced values. A way to print the value context information is also exposed.Some of this logic was already added in #52, but now it is being extended and exposed for general usage.