Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Refactor runtime xt dispatch to return Result #188

Closed
gavofyork opened this issue May 30, 2018 · 1 comment
Closed

Refactor runtime xt dispatch to return Result #188

gavofyork opened this issue May 30, 2018 · 1 comment
Assignees
@gavofyork
Labels
I7-refactor Code needs refactoring.
Milestone
PoC-2 (Co-finalis...

Comments

@gavofyork
Copy link
Member

Currently returns nothing - should instead return Result<(), & 'static str> to ease testing and code quality (means we don't need to use ensure macros - we can just use ?).
@gavofyork gavofyork self-assigned this May 30, 2018
@gavofyork gavofyork added I7-refactor Code needs refactoring. M4-core labels May 30, 2018
@gavofyork gavofyork added this to the PoC-2 (Co-finalisation) milestone May 30, 2018
@rphmeier
Copy link
Contributor

to ease migration of the current usages of assert and expect in the runtime we might want some equivalent macros that do roughly the same thing.

@gavofyork gavofyork mentioned this issue Jun 1, 2018
Merged
lamafab pushed a commit to lamafab/substrate that referenced this issue Jun 16, 2020
@bkchr @rphmeier
Update to latest substrate-master and polkadot v0.3 (paritytech#195)
adba1d5 
* Rebuild runtime

* Remove invalid value from chainspec (paritytech#68)

* service: use grandpa block import for locally sealed aura blocks (paritytech#85)

* bump version to v0.3.1

* Update lock file.

* limit number of transactions when building blocks (paritytech#91)

* Update to latest Substrate

* Bump to 0.3.2

* Actually bump.

* v0.3.2 (paritytech#98)

* bump substrate version

* fix polkadot-collator

* point to alexander-backports of substrate

* bump version

* cli: fix node shutdown (paritytech#100)

* update to latest substrate, change to v0.3.4

* update to latest substrate, bump version to 0.3.5

* v0.3.6

* try to build on every v0.3 commit and update alexander-backports

* bump to v0.3.7

* bump to 0.3.8

* Bump to 0.3.9: network and pruning improvements

* Bump to 0.3.10: reduce network bandwidth usage

* Use libp2p-kad 0.3.2 (paritytech#122)

* Bump libp2p-identify to 0.3.1 (paritytech#123)

* Bump to 0.3.12 (paritytech#127)

* Update Substrate again (paritytech#128)

* update substrate and bump version to v0.3.13

* bump version to v0.3.14: fix --reserved-nodes

* add a manually curated grandpa module (paritytech#136)

* updating v0.3 to use substrate v0.10 (paritytech#146)

* updating to latest substrate v0.10

* better handling of outer poll

* nit

* fix tests

* remove comment

* reduce indentation

* use self.poll

* bring oneshot into scope

* spaces

* wrap

* remove match

* wrap

* Update primitives/Cargo.toml

Co-Authored-By: gterzian <2792687+gterzian@users.noreply.github.com>

* Update runtime/wasm/Cargo.toml

Co-Authored-By: gterzian <2792687+gterzian@users.noreply.github.com>

* Update runtime/wasm/Cargo.toml

Co-Authored-By: gterzian <2792687+gterzian@users.noreply.github.com>

* Update test-parachains/adder/collator/src/main.rs

Co-Authored-By: gterzian <2792687+gterzian@users.noreply.github.com>

* indent

* add paranthese

* config: fix wrong ip for alexander bootnode (paritytech#161)

* fix curated-grandpa and rebuild wasm (paritytech#162)

* [v0.3] Integrates new gossip system into Polkadot (paritytech#166)

* new gossip validation in network

* integrate new gossip into service

* network: guard validation network future under exit signal (paritytech#168)

* bump version to v0.3.15: substrate v0.10

* [v0.3] update to substrate master (paritytech#175)

* update to substrate master

* fix test

* service: fix telemetry endpoints on alexander chainspec (paritytech#169) (paritytech#178)

* Update v0.3 to latest Substrate master (paritytech#177)

* update substrate v0.3 to latest master

* bump spec version

* update to latest master: remove fees module

* update runtime blobs

* bump version to 0.3.16

* replace sr25519 accountid with anysigner

* bump version to v0.3.17

* Some PoC-3 GRANDPA tweaks (paritytech#181)

* call on_finalise after triggering curated_grandpa change

* make grandpa rounds shorter for faster finalization

* use authorities when calculating duty roster (paritytech#185)

* [v0.3] Update to substrate master (paritytech#183)

* update to latest substrate master

* bump version to 0.3.18

* update to latest substrate master

* bump spec version

* update runtime wasm blobs

* remove current_offline_slash from chain spec

* update to substrate master: bump version to v0.3.19 (paritytech#188)

* update to substrate master: bump version to v0.3.19

libp2p network improvements

* network: replace NodeIndex with PeerId

* network: fix tests

* polkadot v0.3.20 (paritytech#190)

* update to substrate master: bump version to 0.3.20

* runtime: add offchain worker trait

* runtime: rebuild wasm blobs

* bump spec version (paritytech#191)

* Fix compilation

* Update version to 0.4.0

* Switch to use `polkadot-master` branch from substrate

* Remove unused struct

* Remove `grandpa::SyncedAuthorities` from `OnSessionChange`
JoshOrndorff added a commit to moonbeam-foundation/substrate that referenced this issue Apr 21, 2021
@JoshOrndorff @4meta5
Only require author id on CLI when node is authoring (paritytech#188)
ecb35f5 
Co-authored-by: 4meta5 <asinghchrony@protonmail.com>
liuchengxu pushed a commit to chainx-org/substrate that referenced this issue Aug 23, 2021
Feature/test case (paritytech#188)
220c960 
ass xassets test case
* assets
* records
* process
liuchengxu added a commit to chainx-org/substrate that referenced this issue Aug 23, 2021
@liuchengxu
Refactor DEX Spot (paritytech#188)
5732531 
* Allow add/update trading pair by root

* Nits

* Add NativeAssetId associate type in Spot

* Rename online to tradable in Spot

* Rename all lowest_offer to lowest_ask

* Write the rpc content directly so that it can be included easier

* Nit

* compact

* compact for StakingRequirement
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gavofyork gavofyork

Labels
I7-refactor Code needs refactoring.
Projects
None yet
Milestone
PoC-2 (Co-finalisation)
Development

No branches or pull requests
2 participants
@gavofyork @rphmeier