This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Runtime dispatch calls return Result
#192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
commented
Jun 1, 2018
| "Parachain heads update extrinsic must be at position {} in the block", | ||
| T::SET_POSITION | ||
| "Parachain heads update extrinsic must be at position {} in the block" | ||
| // , T::SET_POSITION |
There was a problem hiding this comment.
Left in for completeness, but given we're returning &'static str (for efficiency) and have no formatting tools (since it would severely bloat the runtime), I doubt there's much that can be done right now. A later PR could perhaps switch &'static str to String in the case of compiling to native and then it can be formatted properly.
gavofyork
commented
Jun 1, 2018
| $( $x )* | ||
| } | ||
| assert_eq!(h, runtime_io::storage_root()); | ||
| macro_rules! assert_ok { |
There was a problem hiding this comment.
Could be just ?;, I know, but the code looks more uniform with this macro.
arkpar
approved these changes
Jun 1, 2018
|
There are some warnings related to this changeset: https://travis-ci.org/paritytech/polkadot/builds/386366949#L691-L720 |
pepyakin
approved these changes
Jun 1, 2018
JoshOrndorff
added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
* I think I found the issue. * clean up * unused variable * Update pallets/author-inherent/src/lib.rs Co-authored-by: Amar Singh <asinghchrony@protonmail.com> Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
remove transfer to self error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes in after #130
Closes #188
Makes usage cleaner, testing better and paves the way to easily getting rid of almost all panics in the runtime.