This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Introduce CheckNonZeroSender #10413
Merged
Introduce CheckNonZeroSender #10413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-please_review
bkchr
approved these changes
Dec 2, 2021
| @@ -79,6 +79,8 @@ pub enum InvalidTransaction { | |||
| /// A transaction with a mandatory dispatch. This is invalid; only inherent extrinsics are | |||
| /// allowed to have mandatory dispatches. | |||
| MandatoryDispatch, | |||
| /// The sending address is disabled or known to be invalid. | |||
| BadSigner, | |||
There was a problem hiding this comment.
This will require that clients update before.
There was a problem hiding this comment.
I mean it is not a hard requirement, aka we don't break authoring. We will just get a failure on validate_block when trying to decode the return value.
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
…to gav-disable-zero
…to gav-disable-zero
shawntabrizi
approved these changes
Dec 3, 2021
seunlanlege
pushed a commit
to seunlanlege/substrate
that referenced
this pull request
Dec 17, 2021
* Introduce CheckNonZeroSender * Missing file * Formatting * Fixes * Formatting * some fixes to compile * Update frame/system/src/extensions/check_non_zero_sender.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Fixes * Fixes * another fix * Formatting Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Introduce CheckNonZeroSender * Missing file * Formatting * Fixes * Formatting * some fixes to compile * Update frame/system/src/extensions/check_non_zero_sender.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Fixes * Fixes * another fix * Formatting Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
wischli
added a commit
to KILTprotocol/kilt-node
that referenced
this pull request
Jun 2, 2022
12 tasks
jakoblell
added
D1-audited 👍
wischli
added a commit
to KILTprotocol/kilt-node
that referenced
this pull request
Jun 8, 2022
* wip: upgrade to Polkadot v0.9.22 * wip: upgrade to Polkadot v0.9.23 * fix: remove deprecated migrations NOTE: StorageVersion is tracked inside pallet macro * fix: fee calc paritytech/substrate#11415 * chore: bump deps * fix: add missing check for non zero sender paritytech/substrate#10413 * fix: client changes * refactor: downgrade nightly paritytech/substrate#11266 * chore: upgrade to latest nightly supported by Substrate * fix: clippy * fix: clippy * ci: bump srtool to 1.60 * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-treasury --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_treasury.rs --template=.maintain/runtime-weight-template.hbs * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-utility --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_utility.rs --template=.maintain/runtime-weight-template.hbs * fix: rilt spec * fix: remove wip unused file * chore: bump deps Co-authored-by: kiltbot <>
ntn-x2
pushed a commit
to KILTprotocol/kilt-node
that referenced
this pull request
Jun 23, 2022
* wip: upgrade to Polkadot v0.9.22 * wip: upgrade to Polkadot v0.9.23 * fix: remove deprecated migrations NOTE: StorageVersion is tracked inside pallet macro * fix: fee calc paritytech/substrate#11415 * chore: bump deps * fix: add missing check for non zero sender paritytech/substrate#10413 * fix: client changes * refactor: downgrade nightly paritytech/substrate#11266 * chore: upgrade to latest nightly supported by Substrate * fix: clippy * fix: clippy * ci: bump srtool to 1.60 * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-treasury --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_treasury.rs --template=.maintain/runtime-weight-template.hbs * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-utility --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_utility.rs --template=.maintain/runtime-weight-template.hbs * fix: rilt spec * fix: remove wip unused file * chore: bump deps Co-authored-by: kiltbot <> (cherry picked from commit 5e2fec6)
AurevoirXavier
added a commit
to darwinia-network/darwinia-common
that referenced
this pull request
Sep 8, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Introduce CheckNonZeroSender * Missing file * Formatting * Fixes * Formatting * some fixes to compile * Update frame/system/src/extensions/check_non_zero_sender.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Fixes * Fixes * another fix * Formatting Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip check-dependent-cumulus