Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to Polkadot v0.9.23 #366

Merged
merged 18 commits into from
Jun 8, 2022
Merged

feat: upgrade to Polkadot v0.9.23 #366

merged 18 commits into from
Jun 8, 2022

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Jun 1, 2022 •
edited
Loading

fixes KILTProtocol/ticket#2034

TODO

  • Check Rust version (latest nightly 2022-05-31 for now)
  • Check clients
  • Make sure our custom RPC was not removed (big RPC refactor)
  • Tripple check migrations (should be none required for us)
  • Run benchmarks for pallet_treasury and pallet_utility (new functions added to API)
  • Check whether CI is upgraded to newer nightly as well

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@wischli wischli self-assigned this Jun 1, 2022
@wischli wischli requested review from ntn-x2 and trusch June 3, 2022 10:48
@wischli wischli marked this pull request as ready for review June 3, 2022 10:48
@wischli wischli changed the title feat: upgrade to Polkadot v0.9.22 feat: upgrade to Polkadot v0.9.23 Jun 3, 2022
ntn-x2
ntn-x2 approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I see that they have also switched to using srtool 1.60, which we might want to upgrade as well. Not sure if within the scope of this PR, but if not please make a ticket for it.

wischli
wischli commented Jun 7, 2022
View reviewed changes
nodes/parachain/src/rpc.rs
let FullDeps {
client,
pool,
deny_unsafe,
} = deps;

io.extend_with(SystemApi::to_delegate(FullSystem::new(
Copy link
Contributor Author

@wischli wischli Jun 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FullSystem is the important part here. We use(d) this for the NextNonce call. It was refactored to SystemRpc in Substrate #8783 and is now named System. Thus, this PR does not introduce a breaking change.

@KILTprotocol KILTprotocol deleted a comment from kilt-command-bot bot Jun 7, 2022
@wischli
Copy link
Contributor Author

wischli commented Jun 7, 2022

/bench runtime spiritnet-runtime pallet-treasury

@kilt-command-bot
Copy link

kilt-command-bot bot commented Jun 7, 2022 •
edited
Loading

Error running benchmark: wf/2023-polkadot-v0.9.23

stdoutkilt-node repo with runtime is not supported.

@wischli
Copy link
Contributor Author

wischli commented Jun 7, 2022

/bench runtime spiritnet-runtime pallet-treasury

@kilt-command-bot
Copy link

kilt-command-bot bot commented Jun 7, 2022 •
edited
Loading

Error running benchmark: wf/2023-polkadot-v0.9.23

stdoutkilt-node repo with runtime is not supported.

@ggera
Copy link
Member

ggera commented Jun 7, 2022

/bench runtime spiritnet-runtime pallet-treasury

@kilt-command-bot
Copy link

kilt-command-bot bot commented Jun 7, 2022 •
edited
Loading

Error running benchmark: wf/2023-polkadot-v0.9.23

stdoutkilt-node repo with runtime is not supported.

@ggera
Copy link
Member

ggera commented Jun 7, 2022

/bench runtime spiritnet-runtime pallet-treasury

@kilt-command-bot
Copy link

kilt-command-bot bot commented Jun 7, 2022 •
edited
Loading

Error running benchmark: wf/2023-polkadot-v0.9.23

stdoutFrom https://github.com/KILTprotocol/kilt-node * branch develop -> FETCH_HEAD hint: You have divergent branches and need to specify how to reconcile them. hint: You can do so by running one of the following commands sometime before hint: your next pull: hint: hint: git config pull.rebase false # merge (the default strategy) hint: git config pull.rebase true # rebase hint: git config pull.ff only # fast-forward only hint: hint: You can replace "git config" with "git config --global" to set a default hint: preference for all repositories. You can also pass --rebase, --no-rebase, hint: or --ff-only on the command line to override the configured default per hint: invocation. fatal: Need to specify how to reconcile divergent branches.

@wischli
Copy link
Contributor Author

wischli commented Jun 7, 2022

/bench runtime spiritnet-runtime pallet-treasury

@kilt-command-bot
Copy link

kilt-command-bot bot commented Jun 7, 2022 •
edited
Loading

Error running benchmark: wf/2023-polkadot-v0.9.23

stdoutFrom https://github.com/KILTprotocol/kilt-node * branch develop -> FETCH_HEAD hint: You have divergent branches and need to specify how to reconcile them. hint: You can do so by running one of the following commands sometime before hint: your next pull: hint: hint: git config pull.rebase false # merge (the default strategy) hint: git config pull.rebase true # rebase hint: git config pull.ff only # fast-forward only hint: hint: You can replace "git config" with "git config --global" to set a default hint: preference for all repositories. You can also pass --rebase, --no-rebase, hint: or --ff-only on the command line to override the configured default per hint: invocation. fatal: Need to specify how to reconcile divergent branches.

@ggera
Copy link
Member

ggera commented Jun 7, 2022

/bench runtime spiritnet-runtime pallet-treasury

@kilt-command-bot
Copy link

kilt-command-bot bot commented Jun 7, 2022 •
edited
Loading

Error running benchmark: wf/2023-polkadot-v0.9.23

stdoutFrom https://github.com/KILTprotocol/kilt-node * branch develop -> FETCH_HEAD hint: You have divergent branches and need to specify how to reconcile them. hint: You can do so by running one of the following commands sometime before hint: your next pull: hint: hint: git config pull.rebase false # merge (the default strategy) hint: git config pull.rebase true # rebase hint: git config pull.ff only # fast-forward only hint: hint: You can replace "git config" with "git config --global" to set a default hint: preference for all repositories. You can also pass --rebase, --no-rebase, hint: or --ff-only on the command line to override the configured default per hint: invocation. fatal: Need to specify how to reconcile divergent branches.

@ggera
Copy link
Member

ggera commented Jun 7, 2022

/bench runtime spiritnet-runtime pallet-treasury

@kilt-command-bot
Copy link

kilt-command-bot bot commented Jun 7, 2022 •
edited
Loading

Error running benchmark: wf/2023-polkadot-v0.9.23

stdoutFrom https://github.com/KILTprotocol/kilt-node * branch develop -> FETCH_HEAD hint: You have divergent branches and need to specify how to reconcile them. hint: You can do so by running one of the following commands sometime before hint: your next pull: hint: hint: git config pull.rebase false # merge (the default strategy) hint: git config pull.rebase true # rebase hint: git config pull.ff only # fast-forward only hint: hint: You can replace "git config" with "git config --global" to set a default hint: preference for all repositories. You can also pass --rebase, --no-rebase, hint: or --ff-only on the command line to override the configured default per hint: invocation. fatal: Need to specify how to reconcile divergent branches.

@ggera
Copy link
Member

ggera commented Jun 7, 2022

/bench runtime spiritnet-runtime pallet-treasury

1 similar comment
@ggera
Copy link
Member

ggera commented Jun 7, 2022

/bench runtime spiritnet-runtime pallet-treasury

@kilt-command-bot
Copy link

kilt-command-bot bot commented Jun 7, 2022 •
edited
Loading

Benchmark Runtime Pallet for branch "wf/2023-polkadot-v0.9.23" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-treasury --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_treasury.rs --template=.maintain/runtime-weight-template.hbs

Toolchain: nightly-2022-01-08-x86_64-unknown-linux-gnu (default)
rustc 1.59.0-nightly (e012a191d 2022-01-06)

Results 
Wrote dot graph to /home/benchbot/bench-bot/git/kilt-node/target/release/build/orchestra-proc-macro-6d859d449c0904da/out/overseer-subsystem-messaging.dot
Pallet: "pallet_treasury", Extrinsic: "propose_spend", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Treasury ProposalCount (r:1 w:1)
Storage: Treasury Proposals (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    35.42
              µs

Reads = 1
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    35.42
              µs

Reads = 1
Writes = 2

Pallet: "pallet_treasury", Extrinsic: "reject_proposal", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Treasury Proposals (r:1 w:1)
Storage: System Account (r:2 w:2)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    51.98
              µs

Reads = 3
Writes = 3

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    51.98
              µs

Reads = 3
Writes = 3

Pallet: "pallet_treasury", Extrinsic: "approve_proposal", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Treasury Proposals (r:1 w:0)
Storage: Treasury Approvals (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    12.54
    + p    0.154
              µs

Reads = 2 + (0 * p)
Writes = 1 + (0 * p)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    p   mean µs  sigma µs       %
    0     9.396     0.055    0.5%
    1     10.89     0.073    0.6%
    2     11.01     0.102    0.9%
    3     12.19     0.054    0.4%
    4     12.05      0.08    0.6%
    5      12.1     0.081    0.6%
    6        13     0.112    0.8%
    7     12.38     0.138    1.1%
    8     12.97       0.1    0.7%
    9     13.72     0.087    0.6%
   10     13.34     0.146    1.0%
   11     14.19     0.053    0.3%
   12     13.77      0.07    0.5%
   13     14.48     0.112    0.7%
   14     14.14     0.078    0.5%
   15     14.29     0.086    0.6%
   16      14.9     0.114    0.7%
   17     14.69     0.066    0.4%
   18     15.14     0.086    0.5%
   19      15.3     0.074    0.4%
   20     15.09     0.093    0.6%
   21     15.45     0.141    0.9%
   22     16.07     0.135    0.8%
   23     16.19     0.097    0.5%
   24     15.85     0.096    0.6%
   25     16.52     0.082    0.4%
   26     16.81     0.108    0.6%
   27     16.72     0.095    0.5%
   28     17.31     0.142    0.8%
   29      17.5     0.098    0.5%
   30     17.21      0.21    1.2%
   31     17.56      0.07    0.3%
   32     17.88     0.058    0.3%
   33      17.6     0.145    0.8%
   34     18.31     0.134    0.7%
   35     18.56     0.115    0.6%
   36     18.22     0.101    0.5%
   37     18.89     0.086    0.4%
   38     18.31     0.122    0.6%
   39     18.77     0.134    0.7%
   40     18.84     0.154    0.8%
   41     19.34     0.101    0.5%
   42     19.35     0.099    0.5%
   43     20.01     0.127    0.6%
   44     19.75     0.116    0.5%
   45     19.62     0.106    0.5%
   46     19.94     0.148    0.7%
   47     20.11     0.084    0.4%
   48     20.31     0.105    0.5%
   49     20.17     0.093    0.4%
   50     20.82     0.074    0.3%
   51     20.83     0.158    0.7%
   52     20.51     0.158    0.7%
   53      20.7     0.169    0.8%
   54     20.99     0.198    0.9%
   55     21.78      0.07    0.3%
   56     21.38     0.135    0.6%
   57     21.67      0.14    0.6%
   58     21.73     0.124    0.5%
   59     22.24     0.094    0.4%
   60     21.73     0.104    0.4%
   61     21.98     0.075    0.3%
   62     22.28     0.164    0.7%
   63     22.77     0.069    0.3%
   64     22.48     0.201    0.8%
   65     22.93     0.144    0.6%
   66     23.39     0.108    0.4%
   67     22.93     0.079    0.3%
   68     23.41     0.093    0.3%
   69     23.54     0.149    0.6%
   70     23.82      0.15    0.6%
   71     24.27     0.109    0.4%
   72     24.21       0.2    0.8%
   73     24.14     0.073    0.3%
   74     24.74     0.113    0.4%
   75     24.31      0.11    0.4%
   76     24.54     0.181    0.7%
   77     24.62     0.117    0.4%
   78     24.75     0.181    0.7%
   79     24.88     0.267    1.0%
   80      24.3     0.119    0.4%
   81     24.55     0.138    0.5%
   82     25.16     0.364    1.4%
   83     24.39     0.098    0.4%
   84     24.67     0.121    0.4%
   85     24.67     0.175    0.7%
   86     25.54     0.165    0.6%
   87     24.88     0.133    0.5%
   88      25.3     0.097    0.3%
   89      24.9     0.113    0.4%
   90     25.24     0.113    0.4%
   91     25.18     0.174    0.6%
   92     25.09     0.077    0.3%
   93     25.57     0.087    0.3%
   94      25.6     0.149    0.5%
   95     25.76     0.087    0.3%
   96     26.27     0.206    0.7%
   97     25.97      0.18    0.6%
   98     26.41     0.144    0.5%
   99     26.14     0.154    0.5%

Quality and confidence:
param     error
p             0

Model:
Time ~=    12.38
    + p    0.153
              µs

Reads = 2 + (0 * p)
Writes = 1 + (0 * p)

Pallet: "pallet_treasury", Extrinsic: "remove_approval", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Treasury Approvals (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    6.375
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    6.375
              µs

Reads = 1
Writes = 1

Pallet: "pallet_treasury", Extrinsic: "on_initialize_proposals", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: System Account (r:1 w:0)
Storage: Treasury Approvals (r:1 w:1)
Storage: Treasury Proposals (r:2 w:2)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    49.69
    + p    47.41
              µs

Reads = 2 + (3 * p)
Writes = 2 + (3 * p)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    p   mean µs  sigma µs       %
    0     37.27     0.082    0.2%
    2     144.1     0.192    0.1%
    4     240.7     0.311    0.1%
    6     334.8     0.489    0.1%
    8     428.4     0.448    0.1%
   10       525      1.44    0.2%
   12     614.7     1.277    0.2%
   14     714.6     1.442    0.2%
   16     800.9     0.725    0.0%
   18     904.6     9.397    1.0%
   20     987.3     1.917    0.1%
   22      1077     1.426    0.1%
   24      1181     9.735    0.8%
   26      1284     1.495    0.1%
   28      1381     16.42    1.1%
   30      1479     20.17    1.3%
   32      1571     17.68    1.1%
   34      1667     20.03    1.2%
   36      1766     9.032    0.5%
   38      1859     15.09    0.8%
   40      1950     6.619    0.3%
   42      2037     12.04    0.5%
   44      2139     16.13    0.7%
   46      2229     2.248    0.1%
   48      2317     10.87    0.4%
   50      2427     10.71    0.4%
   52      2505     11.24    0.4%
   54      2600     2.347    0.0%
   56      2732     14.85    0.5%
   58      2841     16.51    0.5%
   60      2911     10.55    0.3%
   62      2976     5.774    0.1%
   64      3105     13.94    0.4%
   66      3184     6.599    0.2%
   68      3288      17.1    0.5%
   70      3358       9.3    0.2%
   72      3461     16.72    0.4%
   74      3579     14.08    0.3%
   76      3662     7.967    0.2%
   78      3738     12.38    0.3%
   80      3835     9.345    0.2%
   82      3947     16.43    0.4%
   84      4035     10.88    0.2%
   86      4148     17.08    0.4%
   88      4242     10.31    0.2%
   90      4331     11.39    0.2%
   92      4418     9.051    0.2%
   94      4515     11.17    0.2%
   96      4580     7.146    0.1%
   98      4666      20.7    0.4%
  100      4783     9.633    0.2%

Quality and confidence:
param     error
p         0.025

Model:
Time ~=    49.01
    + p    47.47
              µs

Reads = 2 + (3 * p)
Writes = 2 + (3 * p)

cargo run --quiet --release -p kilt-parachain --features=runtime-benc…
1773e2d 
…hmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-treasury --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_treasury.rs --template=.maintain/runtime-weight-template.hbs
@wischli
Copy link
Contributor Author

wischli commented Jun 7, 2022

/bench runtime spiritnet-runtime pallet-utility

@kilt-command-bot
Copy link

kilt-command-bot bot commented Jun 7, 2022 •
edited
Loading

Benchmark Runtime Pallet for branch "wf/2023-polkadot-v0.9.23" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-utility --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_utility.rs --template=.maintain/runtime-weight-template.hbs

Toolchain: nightly-2022-05-11-x86_64-unknown-linux-gnu (overridden by '/home/benchbot/bench-bot/git/kilt-node/rust-toolchain.toml')
rustc 1.62.0-nightly (ecd44958e 2022-05-10)

Results 
Pallet: "pallet_utility", Extrinsic: "batch", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    19.69
    + c    3.977
              µs

Reads = 0 + (0 * c)
Writes = 0 + (0 * c)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    0     12.52     0.059    0.4%
   20     95.49     0.252    0.2%
   40     179.9     0.394    0.2%
   60     259.9     0.374    0.1%
   80       334     0.532    0.1%
  100     413.4     0.554    0.1%
  120     493.3     0.919    0.1%
  140     572.7     1.122    0.1%
  160     652.2     1.226    0.1%
  180     734.7     1.479    0.2%
  200     815.5     7.084    0.8%
  220     893.3     8.685    0.9%
  240     971.6     9.939    1.0%
  260      1052     3.949    0.3%
  280      1141     9.354    0.8%
  300      1223     11.12    0.9%
  320      1297     12.63    0.9%
  340      1372     11.95    0.8%
  360      1458     8.977    0.6%
  380      1534     13.45    0.8%
  400      1623     17.99    1.1%
  420      1702      17.4    1.0%
  440      1774     16.05    0.9%
  460      1858     11.39    0.6%
  480      1936     11.43    0.5%
  500      2012     11.75    0.5%
  520      2091     16.66    0.7%
  540      2173     11.01    0.5%
  560      2247     9.374    0.4%
  580      2337     7.235    0.3%
  600      2413     15.51    0.6%
  620      2493     7.857    0.3%
  640      2578     11.97    0.4%
  660      2643     10.64    0.4%
  680      2737     7.748    0.2%
  700      2804     8.268    0.2%
  720      2886     10.15    0.3%
  740      2973     8.223    0.2%
  760      3053     9.985    0.3%
  780      3130     4.583    0.1%
  800      3189     9.357    0.2%
  820      3288     11.53    0.3%
  840      3376     8.507    0.2%
  860      3450     8.078    0.2%
  880      3527     5.917    0.1%
  900      3589     7.553    0.2%
  920      3678     7.795    0.2%
  940      3774     14.03    0.3%
  960      3836     10.36    0.2%
  980      3915     8.915    0.2%
 1000      3997     11.01    0.2%

Quality and confidence:
param     error
c         0.001

Model:
Time ~=    19.68
    + c    3.984
              µs

Reads = 0 + (0 * c)
Writes = 0 + (0 * c)

Pallet: "pallet_utility", Extrinsic: "as_derivative", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    2.464
              µs

Reads = 0
Writes = 0

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    2.464
              µs

Reads = 0
Writes = 0

Pallet: "pallet_utility", Extrinsic: "batch_all", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    26.31
    + c    4.312
              µs

Reads = 0 + (0 * c)
Writes = 0 + (0 * c)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    0     17.14     0.186    1.0%
   20     109.5     0.148    0.1%
   40     195.3     2.208    1.1%
   60     279.8     0.691    0.2%
   80       373     3.062    0.8%
  100       452     1.758    0.3%
  120     539.8     1.697    0.3%
  140     628.3     1.428    0.2%
  160     713.1     3.372    0.4%
  180     798.2     2.948    0.3%
  200     882.9     1.943    0.2%
  220     976.6     3.008    0.3%
  240      1061     9.578    0.9%
  260      1154      14.6    1.2%
  280      1245     17.87    1.4%
  300      1322     13.94    1.0%
  320      1409     14.59    1.0%
  340      1488     12.57    0.8%
  360      1584     15.44    0.9%
  380      1669     17.82    1.0%
  400      1762     15.24    0.8%
  420      1838     9.859    0.5%
  440      1941     16.33    0.8%
  460      2012     17.36    0.8%
  480      2097     14.09    0.6%
  500      2181     10.06    0.4%
  520      2286      14.1    0.6%
  540      2367     17.57    0.7%
  560      2447     10.33    0.4%
  580      2534      6.89    0.2%
  600      2612     6.793    0.2%
  620      2709     12.99    0.4%
  640      2803     9.071    0.3%
  660      2875     11.15    0.3%
  680      2967     9.077    0.3%
  700      3063     7.623    0.2%
  720      3120     10.57    0.3%
  740      3228     9.201    0.2%
  760      3325     11.02    0.3%
  780      3392     6.615    0.1%
  800      3507     8.935    0.2%
  820      3572     8.658    0.2%
  840      3639     17.27    0.4%
  860      3738     15.08    0.4%
  880      3823     11.31    0.2%
  900      3908     16.77    0.4%
  920      4002     4.049    0.1%
  940      4092     18.17    0.4%
  960      4159     14.79    0.3%
  980      4232     11.28    0.2%
 1000      4323     11.66    0.2%

Quality and confidence:
param     error
c         0.002

Model:
Time ~=     26.4
    + c    4.319
              µs

Reads = 0 + (0 * c)
Writes = 0 + (0 * c)

Pallet: "pallet_utility", Extrinsic: "dispatch_as", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    13.39
              µs

Reads = 0
Writes = 0

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    13.39
              µs

Reads = 0
Writes = 0

Pallet: "pallet_utility", Extrinsic: "force_batch", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    20.32
    + c    3.987
              µs

Reads = 0 + (0 * c)
Writes = 0 + (0 * c)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    0     12.36     0.141    1.1%
   20     96.98     0.595    0.6%
   40     179.7      0.38    0.2%
   60     259.7     2.465    0.9%
   80     340.4     2.794    0.8%
  100     414.5     0.639    0.1%
  120     492.5      1.18    0.2%
  140     574.4     1.453    0.2%
  160     653.5     1.763    0.2%
  180       736     2.931    0.3%
  200     817.5     5.909    0.7%
  220     893.9      1.86    0.2%
  240     971.7     4.029    0.4%
  260      1057     17.76    1.6%
  280      1134     10.86    0.9%
  300      1218     9.646    0.7%
  320      1296     5.673    0.4%
  340      1375     9.291    0.6%
  360      1460     12.91    0.8%
  380      1545     15.92    1.0%
  400      1630     14.96    0.9%
  420      1716     20.75    1.2%
  440      1786     15.79    0.8%
  460      1863     15.63    0.8%
  480      1941     7.497    0.3%
  500      2028     16.97    0.8%
  520      2104     14.33    0.6%
  540      2180     12.08    0.5%
  560      2257     12.15    0.5%
  580      2351     11.53    0.4%
  600      2438     6.665    0.2%
  620      2520     6.724    0.2%
  640      2579      10.4    0.4%
  660      2669     11.12    0.4%
  680      2750     8.584    0.3%
  700      2831     9.175    0.3%
  720      2884     7.733    0.2%
  740      2977     15.38    0.5%
  760      3053     9.944    0.3%
  780      3146     7.328    0.2%
  800      3207     4.404    0.1%
  820      3299     4.267    0.1%
  840      3371        11    0.3%
  860      3451     4.459    0.1%
  880      3515     12.36    0.3%
  900      3614      14.4    0.3%
  920      3689     5.179    0.1%
  940      3772     4.047    0.1%
  960      3852     10.97    0.2%
  980      3917     8.094    0.2%
 1000      3998     9.818    0.2%

Quality and confidence:
param     error
c         0.002

Model:
Time ~=    21.36
    + c    3.994
              µs

Reads = 0 + (0 * c)
Writes = 0 + (0 * c)

cargo run --quiet --release -p kilt-parachain --features=runtime-benc…
24f7615 
…hmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-utility --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_utility.rs --template=.maintain/runtime-weight-template.hbs
@wischli
Copy link
Contributor Author

wischli commented Jun 7, 2022

LGTM! I see that they have also switched to using srtool 1.60, which we might want to upgrade as well. Not sure if within the scope of this PR, but if not please make a ticket for it.

Ah thanks for the find. Included in ac65d4b

trusch
trusch approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@trusch trusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wischli wischli merged commit 5e2fec6 into develop Jun 8, 2022
@wischli wischli deleted the wf/2023-polkadot-v0.9.23 branch June 8, 2022 11:10
ntn-x2 pushed a commit that referenced this pull request Jun 23, 2022
@wischli @ntn-x2
feat: upgrade to Polkadot v0.9.23 (#366)
7f69985 
* wip: upgrade to Polkadot v0.9.22

* wip: upgrade to Polkadot v0.9.23

* fix: remove deprecated migrations

NOTE: StorageVersion is tracked inside pallet macro

* fix: fee calc

paritytech/substrate#11415

* chore: bump deps

* fix: add missing check for non zero sender

paritytech/substrate#10413

* fix: client changes

* refactor: downgrade nightly

paritytech/substrate#11266

* chore: upgrade to latest nightly supported by Substrate

* fix: clippy

* fix: clippy

* ci: bump srtool to 1.60

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-treasury --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_treasury.rs --template=.maintain/runtime-weight-template.hbs

* cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark pallet --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-utility --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_utility.rs --template=.maintain/runtime-weight-template.hbs

* fix: rilt spec

* fix: remove wip unused file

* chore: bump deps

Co-authored-by: kiltbot <>
(cherry picked from commit 5e2fec6)
ntn-x2 added a commit that referenced this pull request Jun 24, 2022
@ntn-x2
feat: release 1.7.0 (#373)
aa39f8d 
* Adds two more relaychain bootnodes for staging environment  (#334)

* chore: reset peregrine stg (#335)

* ci: use custom ci image (#336)

* Optimizes docker layer (#337)

* fix: add did lookup pallet to DID authorization logic + reverse lookup index (#343)

* chore: update toolchain version to nightly 1.59 (#339)

* feat: proxy type for disableling deposit claiming (#341)

* fix: rococo protocol id (#369)

* feat: generic access control (#316)

* Updates toolchain version (#345)

* refactor: enforce no runtime in pallet (#349)

* fix: features (#353)

* feat: add tips pallet (#352)

* feat: upgrade to Polkadot v0.9.19 (#357)

* chore: upgrade and clean up (#360)

* Adds the new rococo chainspec (#363)

* feat: add launch pallet removal migration (#359)

* refactor: update rilt para id from 2015 to 2108 (#364)

* fix: rilt para id (#365)

* feat: upgrade to Polkadot v0.9.23 (#366)

* use ci-linx:production base image (#368)

* feat: upgrade to Polkadot v0.9.24 (#370)

* fix: fix CI builders compilation errors and pin to a specific hash (#372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntn-x2 ntn-x2 ntn-x2 approved these changes

@trusch trusch trusch approved these changes

Assignees

@wischli wischli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wischli @ggera @trusch @ntn-x2