Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates toolchain version #345

Merged
merged 2 commits into from
Mar 29, 2022
Merged

chore: Updates toolchain version #345

merged 2 commits into from
Mar 29, 2022

Conversation

ggera
Copy link
Member

@ggera ggera commented Mar 25, 2022

NO TICKET

updated the toolchain init script so that the benchbot and ci can call it

@ggera ggera requested review from ntn-x2 and weichweich March 25, 2022 15:24
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to fix the CI Docker images that we use? I made some tests this morning and it was using the old toolchain.

@ggera
Copy link
Member Author

ggera commented Mar 25, 2022

Do we also need to fix the CI Docker images that we use? I made some tests this morning and it was using the old toolchain.

The ci seems to override the docker image toolchain by picking settings in the toolchain file

Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good then 👍

@ntn-x2
Copy link
Member

ntn-x2 commented Mar 28, 2022

I just saw that our release pipeline uses srtool v1.57, when we should probably use v1.59 as our toolchain specifies @ggera

@ggera
Copy link
Member Author

ggera commented Mar 28, 2022

That is correct, the srtool rust version seems hard coded and not sure if it overridable.

@weichweich weichweich enabled auto-merge (squash) March 29, 2022 10:00
@weichweich weichweich merged commit 8bbb261 into develop Mar 29, 2022
@weichweich weichweich deleted the toolchain-update branch March 29, 2022 10:09
ntn-x2 pushed a commit that referenced this pull request Jun 23, 2022
Co-authored-by: William Freudenberger <william@kilt.io>
(cherry picked from commit 8bbb261)
ntn-x2 added a commit that referenced this pull request Jun 24, 2022
* Adds two more relaychain bootnodes for staging environment  (#334)

* chore: reset peregrine stg (#335)

* ci: use custom ci image (#336)

* Optimizes docker layer (#337)

* fix: add did lookup pallet to DID authorization logic + reverse lookup index (#343)

* chore: update toolchain version to nightly 1.59 (#339)

* feat: proxy type for disableling deposit claiming (#341)

* fix: rococo protocol id (#369)

* feat: generic access control (#316)

* Updates toolchain version (#345)

* refactor: enforce no runtime in pallet (#349)

* fix: features (#353)

* feat: add tips pallet (#352)

* feat: upgrade to Polkadot v0.9.19 (#357)

* chore: upgrade and clean up (#360)

* Adds the new rococo chainspec (#363)

* feat: add launch pallet removal migration (#359)

* refactor: update rilt para id from 2015 to 2108 (#364)

* fix: rilt para id (#365)

* feat: upgrade to Polkadot v0.9.23 (#366)

* use ci-linx:production base image (#368)

* feat: upgrade to Polkadot v0.9.24 (#370)

* fix: fix CI builders compilation errors and pin to a specific hash (#372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants