Optimizes docker layer #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was seeing that they changed their Dockerfiles, too so I agree with aligning. @weichweich will have to approve though, since he can judge the changes better here. |
weichweich
approved these changes
Mar 16, 2022
ntn-x2
pushed a commit
that referenced
this pull request
Mar 25, 2022
* Adds copy all files in a sigle layer command * Removes unused docker layer * Changes debian image to ubuntu Co-authored-by: Albrecht <albrecht@kilt.io> (cherry picked from commit 76025b1)
ntn-x2
added a commit
that referenced
this pull request
Mar 25, 2022
* Adds two more relaychain bootnodes for staging environment (#334) * Adds two more bootnodes for staging environment closes #1864 * Fixes staging parachain bootNodes (cherry picked from commit 73097ff) * ci: use caching (cherry picked from commit aafb1a9) * chore: reset peregrine stg (#335) * reset peregrine stg * delete tmp files (cherry picked from commit f27917c) * chore: minor peregrine-stg fix (cherry picked from commit c2819c9) * fix: swapped ed & sr keys (cherry picked from commit dcb7afa) * fix: peregrine-stg bootnodes (cherry picked from commit 30b1cfa) * fix: peregrine-stg parachain nodes (cherry picked from commit 896f01a) * fix: peregrine-stg node identity (cherry picked from commit b84dbda) * ci: use custom ci image (#336) * switch to own ci image skipping one step should speed up the build * add ci dockerfile * add tag (cherry picked from commit e999bfb) * Optimizes docker layer (#337) * Adds copy all files in a sigle layer command * Removes unused docker layer * Changes debian image to ubuntu Co-authored-by: Albrecht <albrecht@kilt.io> (cherry picked from commit 76025b1) * chore: update toolchain version to nightly 1.59 (#339) * chore: bump up toolchain to nightly 1.59 * chore: address Clippy warnings (cherry picked from commit 80182c5) * fix: add did lookup pallet to DID authorization logic + reverse lookup index (#343) * fix: add did lookup pallet to DID authorization logic * test: add unit tests for spiritnet and peregrine runtimes for correct DID verification key derivation * chore: clippy * feat: add additional map for reverse index * test: add unit tests * chore: update benchmarks checks * wip: runtime upgrade scripts * wip: lookup pallet migration * chore: update toolchain version to nightly 1.59 (#339) * chore: bump up toolchain to nightly 1.59 * chore: address Clippy warnings * wip: benchmarks * bench: benchmark compiling * chore: try-runtime complete * chore: update deps * chore: add migrations to Spiritnet runtime * chore: add comment in lookup migration * chore: move migration into lookup pallet * fix: add try-runtime feature to did lookup crate * chore: fixes after rebase * chore: fmt * chore: ConnectedAccounts map comment * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=pallets/pallet-did-lookup/src/default_weights.rs --template=.maintain/weight-template.hbs * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs * bench: update benchmarks to include account replacement as worst case * bench: fix InsufficientFunds error in benchmarks * chore: fmt * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=pallets/pallet-did-lookup/src/default_weights.rs --template=.maintain/weight-template.hbs * chore: update comments * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs Co-authored-by: kiltbot <> (cherry picked from commit ff34f86) * feat: proxy type for disableling deposit claiming (#341) * proxy type for disableling deposit claiming * fix * fix: explicit proxy pallet logic for peregrine runtime * fix: finalise proxy definition for spiritnet * chore: add explicit encoding value for proxy types * chore: update mashnet-node with similar proxy structure as peregrine * chore: clippy * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-proxy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_proxy.rs --template=.maintain/runtime-weight-template.hbs * cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-proxy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_proxy.rs --template=.maintain/runtime-weight-template.hbs Co-authored-by: Antonio Antonino <antonio@kilt.io> Co-authored-by: kiltbot <> (cherry picked from commit a402710) * fix: pallet_did_lookup weights filename * chore: bump pallet and runtime versions Co-authored-by: Gerawork Aynekulu <ggera@users.noreply.github.com> Co-authored-by: weichweich <albrecht@kilt.io>
nazar-pc
reviewed
Apr 1, 2022
Comment on lines
-11
to
-16
| COPY ./nodes /build/nodes | ||
| COPY ./pallets /build/pallets | ||
| COPY ./runtimes /build/runtimes | ||
| COPY ./support /build/support | ||
| COPY ./Cargo.lock /build/Cargo.lock | ||
| COPY ./Cargo.toml /build/Cargo.toml |
There was a problem hiding this comment.
Neither new nor old are great. If there is any layer caching at all, Cargo.toml and Cargo.lock should be copied first, dependencies installed (those don't change often) and then the rest of the code should be copied and the project itself compiled. This way code changes don't result in rebuilding of everything.
There was a problem hiding this comment.
Thanks for the tip! We had dependency caching in our Dockerfile a while ago but experienced some issues. In the end there where some compile errors because of the dependency caching. This and the not so huge improvement by the cache lead us to remove the caching again. Last time we where hoping that cargo-wharf would solve the caching, but it looks like no development was done in 2y.
| @@ -2,6 +2,8 @@ | |||
| .github | |||
| .gitignore | |||
| .gitlab-ci.yml | |||
| .rustfmt.toml | |||
There was a problem hiding this comment.
Ignoring everything and the un-ignoring things that are actually needed for build is typically a more productive approach than block-listing
ntn-x2
added a commit
that referenced
this pull request
Jun 24, 2022
* Adds two more relaychain bootnodes for staging environment (#334) * chore: reset peregrine stg (#335) * ci: use custom ci image (#336) * Optimizes docker layer (#337) * fix: add did lookup pallet to DID authorization logic + reverse lookup index (#343) * chore: update toolchain version to nightly 1.59 (#339) * feat: proxy type for disableling deposit claiming (#341) * fix: rococo protocol id (#369) * feat: generic access control (#316) * Updates toolchain version (#345) * refactor: enforce no runtime in pallet (#349) * fix: features (#353) * feat: add tips pallet (#352) * feat: upgrade to Polkadot v0.9.19 (#357) * chore: upgrade and clean up (#360) * Adds the new rococo chainspec (#363) * feat: add launch pallet removal migration (#359) * refactor: update rilt para id from 2015 to 2108 (#364) * fix: rilt para id (#365) * feat: upgrade to Polkadot v0.9.23 (#366) * use ci-linx:production base image (#368) * feat: upgrade to Polkadot v0.9.24 (#370) * fix: fix CI builders compilation errors and pin to a specific hash (#372)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes kilt-node docker layers: Check polkadot builder for comparison https://github.com/paritytech/polkadot/blob/master/scripts/dockerfiles/polkadot/polkadot_builder.Dockerfile
How to test:
Build a docker image and test if number of layers is lowwered and build time is imrpoved
Checklist:
array[3]useget(3), ...)