This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Manual Seal: Calculate the block's post hash #10498
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes manual seal so that the block hash it returns to the RPC caller is the same hash that can later be used to look the block up in the database.
Previously manual seal was returning the hash of the block as was returned from the
Producer
. That is to say before any signature or other kind of seal was added.This bug was caught by Moonbeam's CI, which also shows that this changes fixes it.
cc @seunlanlege