Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Manual Seal: Calculate the block's post hash #10498

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Manual Seal: Calculate the block's post hash #10498

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa4712c
calculate the post hash
JoshOrndorff Dec 15, 2021
d86b896
Add test
tgmichel Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion client/consensus/manual-seal/src/seal_block.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,14 @@ pub async fn seal_block<B, BI, SC, C, E, TP, CIDP>(
digest_provider.append_block_import(&parent, &mut params, &inherent_data)?;
}

// Make sure we return the same post-hash that will be calculated when importing the block
// This is important in case the digest_provider added any signature, seal, ect.
let mut post_header = header.clone();
post_header.digest_mut().logs.extend(params.post_digests.iter().cloned());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if there's any security risk to calculating the hash up front at this point rather than cloning the header and doing the hash later on?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should that be a security risk?


match block_import.import_block(params, HashMap::new()).await? {
ImportResult::Imported(aux) =>
Ok(CreatedBlock { hash: <B as BlockT>::Header::hash(&header), aux }),
Ok(CreatedBlock { hash: <B as BlockT>::Header::hash(&post_header), aux }),
other => Err(other.into()),
}
};
Expand Down