pallet-lottery: add generate_storage_info #10594

ggwpez · 2022-01-05T17:20:29Z

Adds generate_storage_info to pallet-lottery.
Related paritytech/polkadot-sdk#323

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

shawntabrizi · 2022-01-05T17:24:46Z

Lottery pallet is not deployed to any production runtimes, so it should be fine to merge this without any worries about migrations.

frame/lottery/src/lib.rs

frame/lottery/src/tests.rs

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

frame/lottery/src/tests.rs

ggwpez · 2022-01-06T11:45:51Z

frame/lottery/src/lib.rs

@@ -442,12 +455,12 @@ impl<T: Config> Pallet<T> {
 Error::<T>::AlreadyParticipating


Using a BoundedSet here would make matters easier, but I'm not sure if it is worth the refactor rn.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

frame/lottery/src/lib.rs

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

frame/lottery/src/lib.rs

shawntabrizi · 2022-01-07T17:14:46Z

/benchmark runtime pallet pallet_lottery

parity-benchapp · 2022-01-07T17:14:47Z

Benchmark Runtime Pallet for branch "lottery-bounded-len" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_lottery --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/lottery/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Toolchain: stable-x86_64-unknown-linux-gnu (default)
rustc 1.57.0 (f1edd0429 2021-11-29)

Results

Pallet: "pallet_lottery", Extrinsic: "buy_ticket", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Lottery Lottery (r:1 w:0)
Storage: Lottery CallIndices (r:1 w:0)
Storage: Lottery TicketsCount (r:1 w:1)
Storage: Lottery Participants (r:1 w:1)
Storage: Lottery LotteryIndex (r:1 w:0)
Storage: System Account (r:1 w:1)
Storage: Lottery Tickets (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    53.06
              µs

Reads = 6
Writes = 4

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    53.06
              µs

Reads = 6
Writes = 4

Pallet: "pallet_lottery", Extrinsic: "set_calls", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Lottery CallIndices (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    13.32
    + n    0.387
              µs

Reads = 0 + (0 * n)
Writes = 1 + (0 * n)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    n   mean µs  sigma µs       %
    0     12.56      0.09    0.7%
    1     13.84     0.149    1.0%
    2     14.21     0.117    0.8%
    3     15.17     0.362    2.3%
    4     14.84     0.166    1.1%
    5     15.35     0.165    1.0%
    6     15.57     0.127    0.8%
    7     15.81     0.125    0.7%
    8     16.26     0.144    0.8%
    9     16.94     0.186    1.0%
   10     17.29     0.185    1.0%

Quality and confidence:
param     error
n         0.011

Model:
Time ~=    13.25
    + n    0.402
              µs

Reads = 0 + (0 * n)
Writes = 1 + (0 * n)

Pallet: "pallet_lottery", Extrinsic: "start_lottery", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Lottery Lottery (r:1 w:1)
Storage: Lottery LotteryIndex (r:1 w:1)
Storage: System Account (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    45.04
              µs

Reads = 3
Writes = 3

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    45.04
              µs

Reads = 3
Writes = 3

Pallet: "pallet_lottery", Extrinsic: "stop_repeat", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Lottery Lottery (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    5.732
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    5.732
              µs

Reads = 1
Writes = 1

Pallet: "pallet_lottery", Extrinsic: "on_initialize_end", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: RandomnessCollectiveFlip RandomMaterial (r:1 w:0)
Storage: Lottery Lottery (r:1 w:1)
Storage: System Account (r:2 w:2)
Storage: Lottery TicketsCount (r:1 w:1)
Storage: Lottery Tickets (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    73.89
              µs

Reads = 6
Writes = 4

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    73.89
              µs

Reads = 6
Writes = 4

Pallet: "pallet_lottery", Extrinsic: "on_initialize_repeat", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: RandomnessCollectiveFlip RandomMaterial (r:1 w:0)
Storage: Lottery Lottery (r:1 w:1)
Storage: System Account (r:2 w:2)
Storage: Lottery TicketsCount (r:1 w:1)
Storage: Lottery Tickets (r:1 w:0)
Storage: Lottery LotteryIndex (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    77.32
              µs

Reads = 7
Writes = 5

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    77.32
              µs

Reads = 7
Writes = 5

ERROR: Unable to push ./frame/lottery/src/weights.rs

frame/lottery/src/lib.rs

kianenigma · 2022-01-10T13:17:46Z

frame/lottery/src/benchmarking.rs

+ BoundedVec::<CallIndex, T::MaxCalls>::try_from(vec![
 set_code_index;
 T::MaxCalls::get().saturating_sub(1) as usize
- ],
+ ]).unwrap(),


I recently added a bounded_vec! macro for very basic usages. I think you can easily make it understand vec![_; _] syntax as well and then use it here.

I can't find the macro in the code-base, can you point me to it please?

ahh it is in #10601, maybe you can review it ? :p

not a big deal, we can proceed without it.

Would be good if either of us remembers to come clean it up after the aforementioned PR is merged.

frame/lottery/src/lib.rs

kianenigma

Some small suggestions, but overall looks good! welcome! 🎉

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez · 2022-01-11T14:22:19Z

bot merge

* pallet-preimage: fix crate doc Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_lottery --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/lottery/src/weights.rs --template=./.maintain/frame-weight-template.hbs Co-authored-by: Parity Bot <admin@parity.io>

* pallet-lottery: add generate_storage_info Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * pallet-lottery: test call_to_indices with TooManyCalls Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * review: move try_push above transfer Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * pallet-lottery: test stop_repeat Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * pallet-lottery: test do_buy_ticket as white-box Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * pallet-lottery: use BoundedVec in bechmarks Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * pallet-lottery: fix zero div panic Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * review: extend buy_ticket tests Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * review: test buy_ticket AlreadyParticipating Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * fmt Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * review: use /// comments on private functions Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * review: use with_bounded_capacity Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

) * pallet-preimage: fix crate doc Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_lottery --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/lottery/src/weights.rs --template=./.maintain/frame-weight-template.hbs Co-authored-by: Parity Bot <admin@parity.io>

* pallet-lottery: add generate_storage_info Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * pallet-lottery: test call_to_indices with TooManyCalls Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * review: move try_push above transfer Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * pallet-lottery: test stop_repeat Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * pallet-lottery: test do_buy_ticket as white-box Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * pallet-lottery: use BoundedVec in bechmarks Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * pallet-lottery: fix zero div panic Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * review: extend buy_ticket tests Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * review: test buy_ticket AlreadyParticipating Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * fmt Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * review: use /// comments on private functions Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * review: use with_bounded_capacity Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

) * pallet-preimage: fix crate doc Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_lottery --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/lottery/src/weights.rs --template=./.maintain/frame-weight-template.hbs Co-authored-by: Parity Bot <admin@parity.io>

pallet-lottery: add generate_storage_info

8106370

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez requested a review from shawntabrizi January 5, 2022 17:20

shawntabrizi mentioned this pull request Aug 24, 2023

[FRAME Core] Remove without_storage_info on pallets paritytech/polkadot-sdk#323

Open

40 tasks

shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Jan 5, 2022

shawntabrizi reviewed Jan 5, 2022

View reviewed changes

frame/lottery/src/lib.rs Show resolved Hide resolved

shawntabrizi reviewed Jan 5, 2022

View reviewed changes

frame/lottery/src/tests.rs Show resolved Hide resolved

ggwpez added 4 commits January 5, 2022 19:20

pallet-lottery: test call_to_indices with TooManyCalls

ebad8a9

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

review: move try_push above transfer

b6758bb

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

pallet-lottery: test stop_repeat

df623a9

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

pallet-lottery: test do_buy_ticket as white-box

f0e32fe

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez commented Jan 6, 2022

View reviewed changes

frame/lottery/src/tests.rs Show resolved Hide resolved

ggwpez commented Jan 6, 2022

View reviewed changes

pallet-lottery: use BoundedVec in bechmarks

0fd76a9

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez requested a review from shawntabrizi January 6, 2022 17:10

shawntabrizi reviewed Jan 7, 2022

View reviewed changes

frame/lottery/src/lib.rs Show resolved Hide resolved

ggwpez added 3 commits January 7, 2022 12:15

pallet-lottery: fix zero div panic

91478f1

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

review: extend buy_ticket tests

9a2c732

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

review: test buy_ticket AlreadyParticipating

60133a3

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez requested a review from shawntabrizi January 7, 2022 13:30

shawntabrizi approved these changes Jan 7, 2022

View reviewed changes

ggwpez added 2 commits January 7, 2022 14:50

fmt

39a11be

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Merge remote-tracking branch 'parity/master' into lottery-bounded-len

318da78

ggwpez commented Jan 7, 2022

View reviewed changes

frame/lottery/src/lib.rs Show resolved Hide resolved

kianenigma reviewed Jan 10, 2022

View reviewed changes

frame/lottery/src/lib.rs Outdated Show resolved Hide resolved

kianenigma reviewed Jan 10, 2022

View reviewed changes

frame/lottery/src/lib.rs Outdated Show resolved Hide resolved

kianenigma approved these changes Jan 10, 2022

View reviewed changes

ggwpez added 3 commits January 10, 2022 17:43

review: use /// comments on private functions

1152f5a

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Merge remote-tracking branch 'parity/master' into lottery-bounded-len

c100eec

review: use with_bounded_capacity

64e1b01

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez requested a review from kianenigma January 10, 2022 17:08

kianenigma approved these changes Jan 11, 2022

View reviewed changes

paritytech-processbot bot merged commit a6b7943 into paritytech:master Jan 11, 2022

ggwpez mentioned this pull request Jan 11, 2022

followup #10594: re-benchmark pallet-lottery #10637

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pallet-lottery: add generate_storage_info #10594

pallet-lottery: add generate_storage_info #10594

ggwpez commented Jan 5, 2022 •

edited

Loading

shawntabrizi commented Jan 5, 2022

ggwpez Jan 6, 2022

shawntabrizi commented Jan 7, 2022

parity-benchapp bot commented Jan 7, 2022 •

edited

Loading

kianenigma Jan 10, 2022

ggwpez Jan 10, 2022

kianenigma Jan 11, 2022

kianenigma Jan 11, 2022

ggwpez Jan 11, 2022

kianenigma left a comment

ggwpez commented Jan 11, 2022

		@@ -442,12 +455,12 @@ impl<T: Config> Pallet<T> {
		Error::<T>::AlreadyParticipating

pallet-lottery: add generate_storage_info #10594

pallet-lottery: add generate_storage_info #10594

Conversation

ggwpez commented Jan 5, 2022 • edited Loading

shawntabrizi commented Jan 5, 2022

ggwpez Jan 6, 2022

Choose a reason for hiding this comment

shawntabrizi commented Jan 7, 2022

parity-benchapp bot commented Jan 7, 2022 • edited Loading

kianenigma Jan 10, 2022

Choose a reason for hiding this comment

ggwpez Jan 10, 2022

Choose a reason for hiding this comment

kianenigma Jan 11, 2022

Choose a reason for hiding this comment

kianenigma Jan 11, 2022

Choose a reason for hiding this comment

ggwpez Jan 11, 2022

Choose a reason for hiding this comment

kianenigma left a comment

Choose a reason for hiding this comment

ggwpez commented Jan 11, 2022

ggwpez commented Jan 5, 2022 •

edited

Loading

parity-benchapp bot commented Jan 7, 2022 •

edited

Loading