Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

followup #10594: re-benchmark pallet-lottery #10637

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Jan 11, 2022

Follow up for #10594 to update the weights since I used a fork where the benchmark bot could not push to.
Contains a doc fix so that I can open this MR.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Jan 11, 2022
@ggwpez ggwpez self-assigned this Jan 11, 2022
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jan 11, 2022
@ggwpez
Copy link
Member Author

ggwpez commented Jan 11, 2022

/benchmark runtime pallet pallet_lottery

@parity-benchapp
Copy link

parity-benchapp bot commented Jan 11, 2022

Benchmark Runtime Pallet for branch "oty-lottery-weights" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_lottery --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/lottery/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Toolchain: stable-x86_64-unknown-linux-gnu (default)
rustc 1.57.0 (f1edd0429 2021-11-29)

Results
Pallet: "pallet_lottery", Extrinsic: "buy_ticket", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Lottery Lottery (r:1 w:0)
Storage: Lottery CallIndices (r:1 w:0)
Storage: Lottery TicketsCount (r:1 w:1)
Storage: Lottery Participants (r:1 w:1)
Storage: Lottery LotteryIndex (r:1 w:0)
Storage: System Account (r:1 w:1)
Storage: Lottery Tickets (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    52.21
              µs

Reads = 6
Writes = 4

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    52.21
              µs

Reads = 6
Writes = 4

Pallet: "pallet_lottery", Extrinsic: "set_calls", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Lottery CallIndices (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    13.33
    + n    0.365
              µs

Reads = 0 + (0 * n)
Writes = 1 + (0 * n)

Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    n   mean µs  sigma µs       %
    0     12.77      0.16    1.2%
    1     13.79     0.101    0.7%
    2     14.22     0.085    0.5%
    3     14.35     0.085    0.5%
    4     14.88     0.135    0.9%
    5     15.37     0.151    0.9%
    6     15.61     0.071    0.4%
    7     15.69     0.098    0.6%
    8     16.23     0.098    0.6%
    9     16.66     0.097    0.5%
   10      16.9     0.132    0.7%

Quality and confidence:
param     error
n         0.007

Model:
Time ~=    13.24
    + n    0.378
              µs

Reads = 0 + (0 * n)
Writes = 1 + (0 * n)

Pallet: "pallet_lottery", Extrinsic: "start_lottery", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Lottery Lottery (r:1 w:1)
Storage: Lottery LotteryIndex (r:1 w:1)
Storage: System Account (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    44.63
              µs

Reads = 3
Writes = 3

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    44.63
              µs

Reads = 3
Writes = 3

Pallet: "pallet_lottery", Extrinsic: "stop_repeat", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: Lottery Lottery (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    5.654
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    5.654
              µs

Reads = 1
Writes = 1

Pallet: "pallet_lottery", Extrinsic: "on_initialize_end", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: RandomnessCollectiveFlip RandomMaterial (r:1 w:0)
Storage: Lottery Lottery (r:1 w:1)
Storage: System Account (r:2 w:2)
Storage: Lottery TicketsCount (r:1 w:1)
Storage: Lottery Tickets (r:1 w:0)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    72.99
              µs

Reads = 6
Writes = 4

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    72.99
              µs

Reads = 6
Writes = 4

Pallet: "pallet_lottery", Extrinsic: "on_initialize_repeat", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: RandomnessCollectiveFlip RandomMaterial (r:1 w:0)
Storage: Lottery Lottery (r:1 w:1)
Storage: System Account (r:2 w:2)
Storage: Lottery TicketsCount (r:1 w:1)
Storage: Lottery Tickets (r:1 w:0)
Storage: Lottery LotteryIndex (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    75.32
              µs

Reads = 7
Writes = 5

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    75.32
              µs

Reads = 7
Writes = 5


…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_lottery --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/lottery/src/weights.rs --template=./.maintain/frame-weight-template.hbs
@shawntabrizi shawntabrizi added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Jan 11, 2022
@ggwpez
Copy link
Member Author

ggwpez commented Jan 11, 2022

bot merge

@paritytech-processbot
Copy link

Error: Approval criteria was not satisfied.

The following errors might have affected the outcome of this attempt:

Merge failed. Check out the criteria for merge. If you're not meeting the approval count, check if the approvers are team members of substrateteamleads or core-devs.

@KiChjang
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 75c9609 into master Jan 11, 2022
@paritytech-processbot paritytech-processbot bot deleted the oty-lottery-weights branch January 11, 2022 18:13
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
)

* pallet-preimage: fix crate doc

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_lottery --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/lottery/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Co-authored-by: Parity Bot <admin@parity.io>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
)

* pallet-preimage: fix crate doc

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_lottery --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/lottery/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Co-authored-by: Parity Bot <admin@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants