Fix cargo check for pallet-contracts-proc-macro

[joao-paulo-parity]

close #12705

[joao-paulo-parity]

Curious about why this wasn't being caught before. Are we not running cargo check for each individual crate on CI? That's important for publishing because each crate is published (and therefore checked) individually

[bkchr]

Curious about why this wasn't being caught before

Cargo is merging features in the workspace. Meaning we already have the full feature somewhere enabled in the workspace and thus, it gets enabled here as well when building stuff in the workspace.

[bkchr]

Do we really need full?

[joao-paulo-parity]

Yes. By the error message we can note that cargo is failing to find lots of symbols which are only available if the full feature is enabled. See https://github.com/dtolnay/syn/blob/3424444c7f09a38b97bc2abcd086f7d48732fb51/src/lib.rs#L312-L454. I tried combining a few other features to no avail.

error[E0433]: failed to resolve: could not find `FnArg` in `syn`
   --> frame/contracts/proc-macro/src/lib.rs:286:9
    |
286 |             syn::FnArg::Typed(pt) => Some(&pt.ty),
    |                  ^^^^^ could not find `FnArg` in `syn`

error[E0433]: failed to resolve: could not find `Item` in `syn`
   --> frame/contracts/proc-macro/src/lib.rs:315:9
    |
315 |             syn::Item::Fn(i_fn) => Some(i_fn.clone()),
    |                  ^^^^ could not find `Item` in `syn`

error[E0433]: failed to resolve: could not find `FnArg` in `syn`
   --> frame/contracts/proc-macro/src/lib.rs:406:10
    |
406 |                 syn::FnArg::Typed(pt) => {
    |                      ^^^^^ could not find `FnArg` in `syn`

error[E0433]: failed to resolve: could not find `Pat` in `syn`
   --> frame/contracts/proc-macro/src/lib.rs:407:18
    |
407 |                     if let syn::Pat::Ident(ident) = &*pt.pat {
    |                                 ^^^ could not find `Pat` in `syn`

error[E0412]: cannot find type `ItemFn` in crate `syn`
   --> frame/contracts/proc-macro/src/lib.rs:158:13
    |
158 |     item: syn::ItemFn,
    |                ^^^^^^ not found in `syn`

error[E0412]: cannot find type `ItemFn` in crate `syn`
   --> frame/contracts/proc-macro/src/lib.rs:177:29
    |
177 |     pub fn try_from(item: syn::ItemFn) -> syn::Result<Self> {
    |                                ^^^^^^ not found in `syn`

error[E0412]: cannot find type `ItemMod` in crate `syn`
   --> frame/contracts/proc-macro/src/lib.rs:305:29
    |
305 |     pub fn try_from(item: syn::ItemMod) -> syn::Result<Self> {
    |                                ^^^^^^^ not found in `syn`

error[E0412]: cannot find type `Item` in crate `syn`
   --> frame/contracts/proc-macro/src/lib.rs:314:30
    |
314 |         let extract_fn = |i: &syn::Item| match i {
    |                                    ^^^^ not found in `syn`

error[E0412]: cannot find type `ItemMod` in crate `syn`
   --> frame/contracts/proc-macro/src/lib.rs:578:50
    |
578 |     let item = syn::parse_macro_input!(item as syn::ItemMod);
    |                                                     ^^^^^^^ not found in `syn`

[bkchr]

👍

[joao-paulo-parity]

bot merge