This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Revert "Abstracts elections-phragmen pallet to use NposSolver (#12588)" #13451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4be5dd2.
gpestana
added
A0-please_review
rossbulat
approved these changes
Feb 23, 2023
kianenigma
approved these changes
Feb 23, 2023
ggwpez
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Some benchmarking error blocking the CI https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2435418
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for d49421d |
|
bot merge |
|
Waiting for commit status. |
|
had my dose of flaky CI for the week, if after the restart it is not green I will just manually merge. |
|
Merge cancelled due to error. Error: Statuses failed for d49421d |
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…tech#12588)" (paritytech#13451) This reverts commit 4be5dd2.
ukint-vs
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 10, 2023
…tech#12588)" (paritytech#13451) This reverts commit 4be5dd2.
ukint-vs
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 13, 2023
…tech#12588)" (paritytech#13451) This reverts commit 4be5dd2.
breathx
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 22, 2023
…tech#12588)" (paritytech#13451) This reverts commit 4be5dd2.
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…tech#12588)" (paritytech#13451) This reverts commit 4be5dd2.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4be5dd2 (i.e. #12588)