Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Expose build_system_rpc_future and TransactionPoolAdapator in sc-service #14238

Merged
merged 5 commits into from
May 31, 2023

Conversation

liuchengxu
Copy link
Contributor

@liuchengxu liuchengxu commented May 26, 2023

This change exposes necessary pieces to make replicating build_network possible as we'd like to disable the built-in block sync service so that we use another syncing approach while keeping the rest function of SyncService.

This change allows user to have their own network block logic, for example, we'd like to disable
the builtin block sync service when using another syncing approach.
@dmitry-markin dmitry-markin added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 26, 2023
client/service/src/lib.rs Outdated Show resolved Hide resolved
@liuchengxu liuchengxu changed the title Make block sync service customizable Expose build_system_rpc_future and TransactionPoolAdapator in sc-service May 31, 2023
@altonen
Copy link
Contributor

altonen commented May 31, 2023

I don't see how these change help with custom NetworkBlock implementation but if they do that's great. I'm not the right person to review these changes though

@altonen altonen requested a review from a team May 31, 2023 07:43
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this is an ultra mess, but yeah exposing these two other things will not make this worse...

@bkchr bkchr requested a review from altonen May 31, 2023 12:24
@liuchengxu
Copy link
Contributor Author

@altonen Just to your point, these pieces are needed to replicate build_network() in which I modify the inner build_network_future the removal of the NetworkBlock handle logic which effectively disables the block sync part.

@bkchr bkchr merged commit 7a64651 into paritytech:master May 31, 2023
@liuchengxu liuchengxu deleted the configurable-network-block branch May 31, 2023 16:48
NingLin-P pushed a commit to autonomys/substrate that referenced this pull request Jun 12, 2023
…service (paritytech#14238)

* Make block sync service customizable

This change allows user to have their own network block logic, for example, we'd like to disable
the builtin block sync service when using another syncing approach.

* Remove unnecessary Box

* Revert network_block

* Expose build_system_rpc_future() and TransactionPoolAdaptor

* fmt
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…service (paritytech#14238)

* Make block sync service customizable

This change allows user to have their own network block logic, for example, we'd like to disable
the builtin block sync service when using another syncing approach.

* Remove unnecessary Box

* Revert network_block

* Expose build_system_rpc_future() and TransactionPoolAdaptor

* fmt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants