This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Expose build_system_rpc_future
and TransactionPoolAdapator
in sc-service
#14238
Merged
bkchr
merged 5 commits into
paritytech:master
from
liuchengxu:configurable-network-block
May 31, 2023
Merged
Expose build_system_rpc_future
and TransactionPoolAdapator
in sc-service
#14238
bkchr
merged 5 commits into
paritytech:master
from
liuchengxu:configurable-network-block
May 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows user to have their own network block logic, for example, we'd like to disable the builtin block sync service when using another syncing approach.
dmitry-markin
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
May 26, 2023
altonen
reviewed
May 26, 2023
liuchengxu
changed the title
Make block sync service customizable
Expose May 31, 2023
build_system_rpc_future
and TransactionPoolAdapator
in sc-service
I don't see how these change help with custom |
bkchr
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of this is an ultra mess, but yeah exposing these two other things will not make this worse...
@altonen Just to your point, these pieces are needed to replicate |
altonen
approved these changes
May 31, 2023
NingLin-P
pushed a commit
to autonomys/substrate
that referenced
this pull request
Jun 12, 2023
…service (paritytech#14238) * Make block sync service customizable This change allows user to have their own network block logic, for example, we'd like to disable the builtin block sync service when using another syncing approach. * Remove unnecessary Box * Revert network_block * Expose build_system_rpc_future() and TransactionPoolAdaptor * fmt
This was referenced Jun 12, 2023
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…service (paritytech#14238) * Make block sync service customizable This change allows user to have their own network block logic, for example, we'd like to disable the builtin block sync service when using another syncing approach. * Remove unnecessary Box * Revert network_block * Expose build_system_rpc_future() and TransactionPoolAdaptor * fmt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change exposes necessary pieces to make replicating
build_network
possible as we'd like to disable the built-in block sync service so that we use another syncing approach while keeping the rest function ofSyncService
.