Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Contracts: Enabled signed extension (#14565) #14626

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

ascjones
Copy link
Contributor

See #14565.

Required for substrate-contracts-node to support Rust >= 1.70 via paritytech/substrate-contracts-node#195

* Contracts enable signed extension

* Add test

* fix

* xx

* Update frame/contracts/fixtures/sign_extension.wat

Co-authored-by: Sasha Gryaznov <hi@agryaznov.com>

* move tests

---------

Co-authored-by: Sasha Gryaznov <hi@agryaznov.com>
@ascjones ascjones requested a review from athei as a code owner July 24, 2023 18:11
@ascjones ascjones requested a review from a team July 24, 2023 18:11
@ascjones ascjones added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. A6-backport Pull request is already reviewed well in another branch. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 24, 2023
@SkymanOne SkymanOne merged commit 40e3395 into polkadot-v1.0.0 Jul 24, 2023
@SkymanOne SkymanOne deleted the aj/add_code_len branch July 24, 2023 19:05
@coderobe
Copy link

@SkymanOne please don't merge into release branches before releng approval

@athei
Copy link
Member

athei commented Jul 24, 2023

Hey sorry. I told him it was okay because:

  1. Source code compatible
  2. Not used on relay chain

What are the criteria for approval?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A6-backport Pull request is already reviewed well in another branch. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants