Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Extend SS58 network identifiers #8039

Merged
14 commits merged into from
Feb 6, 2021
Merged

Extend SS58 network identifiers #8039

14 commits merged into from
Feb 6, 2021

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork commented Feb 3, 2021 •
edited
Loading

Implement extended SS58 network ids; this enables network ids of values 48..16,383.

CC @apopiak

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Feb 3, 2021
@jacogr jacogr mentioned this pull request Feb 3, 2021
Merged
@gavofyork gavofyork added C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Feb 3, 2021
@apopiak
Copy link
Contributor

apopiak commented Feb 4, 2021

relates to #4927

gui1117
gui1117 approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@apopiak apopiak mentioned this pull request Feb 5, 2021
Merged
bkchr
bkchr approved these changes Feb 5, 2021
View reviewed changes
primitives/core/src/ecdsa.rs Outdated Show resolved Hide resolved
primitives/core/src/crypto.rs Outdated Show resolved Hide resolved
primitives/core/src/crypto.rs Outdated Show resolved Hide resolved
@gavofyork @bkchr
Update primitives/core/src/crypto.rs
8207a78 
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
@gavofyork
Copy link
Member Author

bot merge

@ghost
Copy link

ghost commented Feb 6, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Feb 6, 2021

Checks failed; merge aborted.

@gavofyork
Copy link
Member Author

bot merge

@ghost
Copy link

ghost commented Feb 6, 2021

Waiting for commit status.

@ghost ghost merged commit 26e9a11 into master Feb 6, 2021
@ghost ghost deleted the gav-extended-ss58 branch February 6, 2021 15:00
@arjanz arjanz mentioned this pull request Feb 6, 2021
Closed
@tomusdrw tomusdrw mentioned this pull request Feb 12, 2021
Closed
@xlc xlc mentioned this pull request Feb 24, 2021
Closed
@jakoblell jakoblell added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jun 1, 2021
@mikiquantum mikiquantum mentioned this pull request Jun 9, 2021
Merged
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi left review comments

@jacogr jacogr jacogr left review comments

@gui1117 gui1117 gui1117 approved these changes

@apopiak apopiak apopiak approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gavofyork @apopiak @jacogr @shawntabrizi @bkchr @gui1117 @jakoblell