This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add Aventus ss58 address #8050
Merged
Add Aventus ss58 address #8050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apopiak
added
A0-please_review
apopiak
reviewed
Feb 5, 2021
joepetrowski
reviewed
Feb 5, 2021
There was a problem hiding this comment.
Reserved prefixes are generally not available to be claimed. @gavofyork ?
As discussed on Element, teams planning to launch soon can get prefixes <64 so they don't have to wait for the SS58 extension update happening here: #8039 |
bkchr
previously approved these changes
Feb 5, 2021
|
@gavofyork I did see that you marked 46 and 47 as reserved in the SS58 PR, so should Aventus pick a different one? |
bkchr
approved these changes
Feb 8, 2021
|
@nahuseyoum please merge master |
|
Master merge needed. Also, please change the index to one > 64. |
|
Prefix updated to 65 and merged from master. |
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ss58 prefix (65) for the Aventus mainnet chain which will go live shortly. Companion PR for polkadot.js PR#871