Fix doc build with --all-features

[gui1117]

this fixes the cmd: RUSTDOCFLAGS="-Dwarnings" time cargo +nightly doc --no-deps --workspace --all-features

Some outdated doc in network + link to private item

Some doc in sc_network were outdated, and some were linking to private item. I'm not sure how to solve them so I just remove the invalid link. But some are still outdated. (maybe cc @tomaka )

Issue with feature try-runtime

The feature try-runtime is breaking the build for unknown reason: (to reproduce go to the first commit 16b38eb and execute the cmd: RUSTDOCFLAGS="-Dwarnings" time cargo +nightly doc --no-deps --workspace --all-features)

error[E0046]: not all trait items implemented, missing: `pre_upgrade`, `post_upgrade`
  --> test-utils/runtime/src/system.rs:44:1
   |
44 | / decl_module! {
45 | |     pub struct Module<T: Config> for enum Call where origin: T::Origin {}
46 | | }
   | |_^ missing `pre_upgrade`, `post_upgrade` in implementation
   |
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
   = help: implement the missing item: `fn pre_upgrade() -> sc_service::Result<(), &'static str> { todo!() }`
   = help: implement the missing item: `fn post_upgrade() -> sc_service::Result<(), &'static str> { todo!() }`

Thus I actually implemented in the trait OnRuntimeUpgrade the default implementation for pre_upgrade and post_upgrade. The disadvantage is that if node-runtime forget to bound my-pallet/try-runtime in its Cargo.toml then the pallet implementation will simply be ignored.

[tomaka]

I'd prefer to not go for this solution of "un-linking" the dead links.

The problem is that the documentation is outdated. Doc-links can detect when the documentation is outdated. If you disable the doc-links, it doesn't solve the problem of the documentation being outdated. You're just killing the messenger.

[gui1117]

the compilation is failing because debug doesn't exist anymore cc @kianenigma

I think logger is automatically initialized now, so we can remove no ?

[kianenigma]

Yeah this should be removed, and I think there might be other places in try-runtime that we use this the deprecated logger as well.

I've made an issue here: https://github.com/paritytech/ci_cd/issues/103, I hope we have this in the CI soon.

[tomaka]

Unless this is urgent, please either do all the appropriate changes in sc-network or (more likely) revert so that I do it later.

[gui1117]

this is private item

[gui1117]

Unless this is urgent, please either do all the appropriate changes in sc-network or (more likely) revert so that I do it later.

yes, sorry done

[kianenigma]

If there are further doc-related issues, I'd be happy of the fixes that are related to try-runtime to get extracted out and merged, as other PRs are waiting for them. I can help with this if needed 👍

[gui1117]

This PR was more a draft for the stuff needed to change, if you need the try-runtime changes feel free to take them.

Sorry if it felt pushing, I'm also not entirely convinced if it is the good way of addressing try-runtime issue.

[gui1117]

bot merge

[ghost]

Checks failed; merge aborted.