This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix doc build with --all-features #8277
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,13 +43,13 @@ | |
//! | ||
//! Each of the phases can be disabled by essentially setting their length to zero. If both phases | ||
//! have length zero, then the pallet essentially runs only the fallback strategy, denoted by | ||
//! [`Config::FallbackStrategy`]. | ||
//! [`Config::Fallback`]. | ||
//! ### Signed Phase | ||
//! | ||
//! In the signed phase, solutions (of type [`RawSolution`]) are submitted and queued on chain. A | ||
//! deposit is reserved, based on the size of the solution, for the cost of keeping this solution | ||
//! on-chain for a number of blocks, and the potential weight of the solution upon being checked. A | ||
//! maximum of [`pallet::Config::MaxSignedSubmissions`] solutions are stored. The queue is always | ||
//! maximum of `pallet::Config::MaxSignedSubmissions` solutions are stored. The queue is always | ||
//! sorted based on score (worse to best). | ||
//! | ||
//! Upon arrival of a new solution: | ||
|
@@ -65,7 +65,7 @@ | |
//! origin can not bail out in any way, if their solution is queued. | ||
//! | ||
//! Upon the end of the signed phase, the solutions are examined from best to worse (i.e. `pop()`ed | ||
//! until drained). Each solution undergoes an expensive [`Pallet::feasibility_check`], which | ||
//! until drained). Each solution undergoes an expensive `Pallet::feasibility_check`, which | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is private item |
||
//! ensures the score claimed by this score was correct, and it is valid based on the election data | ||
//! (i.e. votes and candidates). At each step, if the current best solution passes the feasibility | ||
//! check, it is considered to be the best one. The sender of the origin is rewarded, and the rest | ||
|
@@ -192,14 +192,14 @@ | |
//! **Score based on (byte) size**: We should always prioritize small solutions over bigger ones, if | ||
//! there is a tie. Even more harsh should be to enforce the bound of the `reduce` algorithm. | ||
//! | ||
//! **Offchain resubmit**: Essentially port https://github.com/paritytech/substrate/pull/7976 to | ||
//! **Offchain resubmit**: Essentially port <https://github.com/paritytech/substrate/pull/7976> to | ||
//! this pallet as well. The `OFFCHAIN_REPEAT` also needs to become an adjustable parameter of the | ||
//! pallet. | ||
//! | ||
//! **Make the number of nominators configurable from the runtime**. Remove `sp_npos_elections` | ||
//! dependency from staking and the compact solution type. It should be generated at runtime, there | ||
//! it should be encoded how many votes each nominators have. Essentially translate | ||
//! https://github.com/paritytech/substrate/pull/7929 to this pallet. | ||
//! <https://github.com/paritytech/substrate/pull/7929> to this pallet. | ||
|
||
#![cfg_attr(not(feature = "std"), no_std)] | ||
|
||
|
@@ -364,7 +364,7 @@ impl Default for ElectionCompute { | |
/// This is what will get submitted to the chain. | ||
/// | ||
/// Such a solution should never become effective in anyway before being checked by the | ||
/// [`Pallet::feasibility_check`] | ||
/// `Pallet::feasibility_check` | ||
#[derive(PartialEq, Eq, Clone, Encode, Decode, RuntimeDebug)] | ||
pub struct RawSolution<C> { | ||
/// Compact election edges. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,3 +41,4 @@ std = [ | |
"sp-std/std" | ||
] | ||
runtime-benchmarks = ["frame-benchmarking"] | ||
try-runtime = ["frame-support/try-runtime"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,3 +41,4 @@ std = [ | |
"sp-runtime/std", | ||
"sp-state-machine", | ||
] | ||
try-runtime = ["frame-support/try-runtime"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the compilation is failing because debug doesn't exist anymore cc @kianenigma
I think logger is automatically initialized now, so we can remove no ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this should be removed, and I think there might be other places in
try-runtime
that we use this the deprecated logger as well.I've made an issue here: https://github.com/paritytech/ci_cd/issues/103, I hope we have this in the CI soon.