Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix companion check #8464

Merged
1 commit merged into from
Mar 26, 2021
Merged

Fix companion check #8464

1 commit merged into from
Mar 26, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Mar 26, 2021

Fix: #8460

@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 26, 2021
@bkchr bkchr requested a review from a team as a code owner March 26, 2021 14:24
@gui1117
Copy link
Contributor

gui1117 commented Mar 26, 2021

bot merge

@ghost
Copy link

ghost commented Mar 26, 2021

Waiting for commit status.

@ghost ghost merged commit f16abda into master Mar 26, 2021
@ghost ghost deleted the bkchr-fix-companion-check branch March 26, 2021 14:59
ordian added a commit that referenced this pull request Mar 31, 2021
@ordian
Merge branch 'master' into ao-update-wasmtime
ded49c0 
* master: (84 commits)
  Duplicate logging to stdout (#8495)
  Fix sync restart (#8497)
  client: fix justifications migration (#8489)
  helper macro to create storage types on the fly (#8456)
  Make `BlockImport` and `Verifier` async (#8472)
  Get rid of `test-helpers` feature in sc-consensus-babe (#8486)
  Enhancement on Substrate Node Template (#8473)
  Add Social Network (#8065)
  Prepare UI tests for Rust 1.51 & new CI image (#8474)
  Benchmarking pallet-example (#8301)
  Use pathbuf for remote externalities (#8480)
  Bring back the on_finalize weight of staking. (#8463)
  Implement `fungible::*` for Balances (#8454)
  make types within `generate_solution_type` macro explicit (#8447)
  [pallet-staking] Refund unused weight for `payout_stakers` (#8458)
  Use `async_trait` in sc-consensus-slots (#8461)
  Repot frame_support::traits; introduce some new currency stuff (#8435)
  Fix &mut self -> &self in add_known_address (#8468)
  Add NetworkService::add_known_address (#8467)
  Fix companion check (#8464)
  ...
hirschenberger pushed a commit to hirschenberger/substrate that referenced this pull request Apr 14, 2021
@bkchr @hirschenberger
Fix companion check (paritytech#8464)
8823362
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@gui1117 gui1117 gui1117 approved these changes

@TriplEight TriplEight Awaiting requested review from TriplEight

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkchr @gui1117 @shawntabrizi