This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Enhancement on Substrate Node Template #8473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
…ubstrate-node-template Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
kianenigma
added
B0-silent
kianenigma
reviewed
Mar 28, 2021
kianenigma
reviewed
Mar 28, 2021
kianenigma
reviewed
Mar 28, 2021
kianenigma
reviewed
Mar 28, 2021
kianenigma
approved these changes
Mar 28, 2021
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
jimmychu0807
commented
Mar 29, 2021
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
|
thanks @kianenigma for the review. Addressed all of your concerns, and about docker script I will deal with it in a separate issue. |
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
The node template here should works with latest Substrate, even though these features may not have been released in crate.io Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
…strate to published packages Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
apopiak
reviewed
Mar 29, 2021
Comment on lines
+50
to
+51
| P.S: This step can be automated if we update `node-template-release` package in | ||
| `.maintain/node-template-release`. |
There was a problem hiding this comment.
It is. But given there are 626 issues in Substrate repo already, I don't want to add another one that is kind of low priority.
There was a problem hiding this comment.
I don't think it makes sense not to create issues and have things in code, but 🤷
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
|
@apopiak thanks for the review 🙏 |
apopiak
approved these changes
Mar 29, 2021
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
s3krit
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
Awesome to see we're documenting this more. I'll need to look into this a lot more to think about how we can better improve the automation for releasing node-template in the future, but in the meantime this is a really good change. Glad to see it's being documented :)
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
| [*] | ||
| indent_style=space | ||
| indent_size=2 | ||
| tab_width=2 |
There was a problem hiding this comment.
did we want to commit this file?
ordian
added a commit
that referenced
this pull request
Mar 31, 2021
* master: (84 commits) Duplicate logging to stdout (#8495) Fix sync restart (#8497) client: fix justifications migration (#8489) helper macro to create storage types on the fly (#8456) Make `BlockImport` and `Verifier` async (#8472) Get rid of `test-helpers` feature in sc-consensus-babe (#8486) Enhancement on Substrate Node Template (#8473) Add Social Network (#8065) Prepare UI tests for Rust 1.51 & new CI image (#8474) Benchmarking pallet-example (#8301) Use pathbuf for remote externalities (#8480) Bring back the on_finalize weight of staking. (#8463) Implement `fungible::*` for Balances (#8454) make types within `generate_solution_type` macro explicit (#8447) [pallet-staking] Refund unused weight for `payout_stakers` (#8458) Use `async_trait` in sc-consensus-slots (#8461) Repot frame_support::traits; introduce some new currency stuff (#8435) Fix &mut self -> &self in add_known_address (#8468) Add NetworkService::add_known_address (#8467) Fix companion check (#8464) ...
hirschenberger
pushed a commit
to hirschenberger/substrate
that referenced
this pull request
Apr 14, 2021
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.0.0spec_versionin runtime is set to 100node-template-release.shscript is directly using the path passed in instead of forcing to use a relative path.