This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Simplify math by using MAX associated const #9189
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
u32::MAX
rather thanu32::max_value()
. Easier to read code.(I will do the min as a separate PR so that it's a little easier to review the PR - unless you'd prefer them both in the same?)
(Also should we have
Weight::MAX
,BallanceOf::<T>::MAX
andBounded::MAX
? if so happy to do that in a separate PR)