Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add field names to pallet Event variants #9993

Merged
merged 20 commits into from
Nov 16, 2021
Merged

Add field names to pallet Event variants #9993

merged 20 commits into from
Nov 16, 2021

Conversation

Wizdave97
Copy link
Contributor

@Wizdave97 Wizdave97 commented Oct 11, 2021 •
edited
Loading

Description

This PR changes the pallet events variants from tuples to structs with named fields

Part implementation for #9903

Pallets updated

Sorted alphabetically in the frame folder assets - proxy

polkadot companion: paritytech/polkadot#4262
cumulus companion: paritytech/cumulus#749

Polkadot address: 1xazYr2XULzE3kjWCbuzKNcykfbjdgJGeSD6n3RvhdSikJf

@Wizdave97 Wizdave97 changed the title Wiz field names to pallet events Add field names to pallet Event variants Oct 11, 2021
@shawntabrizi shawntabrizi added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. B0-silent Changes should not be mentioned in any release notes D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Oct 11, 2021
@shawntabrizi
Copy link
Member

Looking good wizdave.

Feel free to scope PRs to a few pallets at a time, so that it is easier to review, give fedback, and get merged.

You can do multiple PRs here to migrate them all over time.

@Wizdave97 Wizdave97 force-pushed the wiz-field-names-to-pallet-events branch from 92c01e0 to 98b3178 Compare October 26, 2021 08:31
@Wizdave97 Wizdave97 marked this pull request as ready for review October 26, 2021 08:31
@Wizdave97
Copy link
Contributor Author

Looking good wizdave.

Feel free to scope PRs to a few pallets at a time, so that it is easier to review, give fedback, and get merged.

You can do multiple PRs here to migrate them all over time.

Pallets updated
Sorted alphabetically in the frame folder assets - proxy

kianenigma
kianenigma previously requested changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run cargo +nightly fmt?

@Wizdave97
Copy link
Contributor Author

Did you run cargo +nightly fmt?

Just did that

gui1117
gui1117 reviewed Oct 29, 2021
View reviewed changes
frame/balances/src/lib.rs Outdated Show resolved Hide resolved
gui1117
gui1117 reviewed Oct 29, 2021
View reviewed changes
frame/balances/src/lib.rs Outdated Show resolved Hide resolved
@Wizdave97 Wizdave97 mentioned this pull request Nov 11, 2021
Merged
@KiChjang
Copy link
Contributor

@Wizdave97 I've added them to your PR description. The CI bots will only read that to determine where the companion PRs are, instead of new github comments.

@Wizdave97
Copy link
Contributor Author

@Wizdave97 I've added them to your PR description. The CI bots will only read that to determine where the companion PRs are, instead of new github comments.

@KiChjang Do i need to rerun the CI jobs again after this?

@KiChjang
Copy link
Contributor

@Wizdave97 Shouldn't need to; if I'm not mistaken, there is a github hook on every edit of the PR description box, and the CI bots pick up on that.

@Wizdave97
Copy link
Contributor Author

@Wizdave97 Shouldn't need to; if I'm not mistaken, there is a github hook on every edit of the PR description box, and the CI bots pick up on that.

@KiChjang All done

@Doordashcon Doordashcon mentioned this pull request Nov 13, 2021
Merged
@Wizdave97
Copy link
Contributor Author

@shawntabrizi @kianenigma Could you please review this and it's companon PRs

gui1117
gui1117 approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@gui1117
Copy link
Contributor

gui1117 commented Nov 16, 2021

bot merge

@paritytech-processbot paritytech-processbot bot merged commit c087bbe into paritytech:master Nov 16, 2021
@Wizdave97 Wizdave97 deleted the wiz-field-names-to-pallet-events branch November 16, 2021 08:37
@athei
Copy link
Member

athei commented Nov 16, 2021

/tip large

@substrate-tip-bot
Copy link

A large tip was successfully submitted for Wizdave97 (1xazYr2XULzE3kjWCbuzKNcykfbjdgJGeSD6n3RvhdSikJf on polkadot).

https://polkadot.js.org/apps/#/treasury/tips

@Wizdave97
Copy link
Contributor Author

/tip large

Thank you.

@ECJ222 ECJ222 mentioned this pull request Nov 17, 2021
Merged
@jasl jasl mentioned this pull request Nov 26, 2021
Merged
@lukanus lukanus mentioned this pull request Jan 28, 2022
Closed
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
@Wizdave97 @grishasobol
Add field names to pallet Event variants (paritytech#9993)
91175f1 
* convert pallet-assets events to struct types

* updated events of a couple pallets

* updated pallet event field names

* update pallet event field names

* updated events in test files

* cargo fmt

* minorfixes

* fix assertion error

* minor fix

* formatting fix

* fmt
@AurevoirXavier AurevoirXavier mentioned this pull request Feb 7, 2023
Closed
12 tasks
@Wizdave97 Wizdave97 mentioned this pull request Oct 8, 2022
Merged
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@Wizdave97 @ark0f
Add field names to pallet Event variants (paritytech#9993)
c08cc21 
* convert pallet-assets events to struct types

* updated events of a couple pallets

* updated pallet event field names

* update pallet event field names

* updated events in test files

* cargo fmt

* minorfixes

* fix assertion error

* minor fix

* formatting fix

* fmt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@athei athei athei approved these changes

@adoerr adoerr Awaiting requested review from adoerr

@andresilva andresilva Awaiting requested review from andresilva

@shawntabrizi shawntabrizi Awaiting requested review from shawntabrizi

@kianenigma kianenigma Awaiting requested review from kianenigma

@emostov emostov Awaiting requested review from emostov

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Wizdave97 @shawntabrizi @athei @KiChjang @gui1117 @kianenigma @emostov