Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add pallet names to Events #10296

Merged
merged 46 commits into from
Nov 30, 2021
Merged

Add pallet names to Events #10296

merged 46 commits into from
Nov 30, 2021

Conversation

ECJ222
Copy link
Contributor

@ECJ222 ECJ222 commented Nov 17, 2021

This PR changes the pallet events variants from tuples to structs with named fields

Part implementation for #9903, #9993, #10184, #10206, #10257

Pallets with changes

  • scheduler
  • society
  • system
  • treasury
  • transaction-storage
  • utility

I also made a few changes to the following pallets after I changed the pallet events variants from tuples to structs with named fields in the system pallet. i.e NewAccount, KilledAccount, Remarked.

  • balances
  • contracts
  • offences
  • transaction-payment

polkadot companion: paritytech/polkadot#4339

Polkadot address: 13g44iYtkxLZ2tkp6iTJiqs7yEiEr4bVsPZTueWDjd6Bor1P

@ECJ222 ECJ222 requested a review from athei as a code owner November 17, 2021 10:18
@ECJ222 ECJ222 closed this Nov 17, 2021
@ECJ222 ECJ222 reopened this Nov 17, 2021
@athei athei added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Nov 17, 2021
@ECJ222
Copy link
Contributor Author

ECJ222 commented Nov 26, 2021

I seems that I misunderstood how the companion CI works these days. It appears that the failing job is expected when applying a breaking change. I will need to check whether it is OK to merge.

Okay @athei.

@KiChjang
Copy link
Contributor

CI is not making any damn sense to me, I've restarted it multiple times but it still errors on the event types on the companion PR, but then the companion PR CI is all passing! I've no idea what's going on here, it's all arcane magic to me. cc @paritytech/ci

@bkchr
Copy link
Member

bkchr commented Nov 27, 2021

bot merge

@paritytech-processbot
Copy link

Error: Response error (status 404 Not Found):

{"documentation_url":"https://docs.github.com/rest/reference/pulls#get-a-pull-request","message":"Not Found"}

@bkchr
Copy link
Member

bkchr commented Nov 27, 2021

bot merge force

@paritytech-processbot
Copy link

Error: Response error (status 404 Not Found):

{"documentation_url":"https://docs.github.com/rest/reference/pulls#get-a-pull-request","message":"Not Found"}

@bkchr
Copy link
Member

bkchr commented Nov 27, 2021

bot merge

@paritytech-processbot
Copy link

Error: Response error (status 404 Not Found):

{"documentation_url":"https://docs.github.com/rest/reference/pulls#get-a-pull-request","message":"Not Found"}

@ECJ222
Copy link
Contributor Author

ECJ222 commented Nov 28, 2021

Hi @bkchr,

Hope you are having a great day, please do you know why this error occurs Error: Response error (status 404 Not Found) when you try the bot merge command?

@athei
Copy link
Member

athei commented Nov 29, 2021

bot merge

@paritytech-processbot
Copy link

Error: Github API says paritytech/polkadot#4339 is not mergeable

@bkchr
Copy link
Member

bkchr commented Nov 30, 2021

bot merge

@paritytech-processbot
Copy link

Error: Response error (status 404 Not Found):

{"documentation_url":"https://docs.github.com/rest/reference/pulls#get-a-pull-request","message":"Not Found"}

@bkchr bkchr merged commit 4bef50f into paritytech:master Nov 30, 2021
@bkchr
Copy link
Member

bkchr commented Nov 30, 2021

/tip medium

1 similar comment
@bkchr
Copy link
Member

bkchr commented Nov 30, 2021

/tip medium

@substrate-tip-bot
Copy link

A medium tip was successfully submitted for ECJ222 (13g44iYtkxLZ2tkp6iTJiqs7yEiEr4bVsPZTueWDjd6Bor1P on polkadot).

https://polkadot.js.org/apps/#/treasury/tips

niklasad1 added a commit that referenced this pull request Dec 2, 2021
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: formatted pallet name changes in events

* chore: formatted pallet name changes in events

* chore: formatted pallet name changes in events

* chore: formatted pallet name changes in events

* chore: formatted pallet name changes in events

* chore: formatted pallet name changes in events

* chore: formatted pallet name changes in events

* chore: formatted pallet name changes in events

* chore: formatted pallet name changes in events

* fix: add fix to tests for event variants

* chore: modified comments for event variants

* chore: modified comments for event variants

* chore: modified comments for event variants

* chore: modified comments for event variants

* chore: modified system pallet event variants

* chore: modified system pallet event variants

* chore: modified system pallet event variants

* chore: modified system pallet event variants

* chore: modified system pallet event variants

* chore: modified system pallet event variants

* chore: modified system pallet event variants

* chore: modified system pallet event variants

* chore: modified system pallet event variants

* chore: updated transaction-storage pallet event variants

* chore: updated transaction-storage pallet event variants

* chore: formatted contracts pallet

* chore: update treasury event variants
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: add pallet names to events

* chore: formatted pallet name changes in events

* chore: formatted pallet name changes in events

* chore: formatted pallet name changes in events

* chore: formatted pallet name changes in events

* chore: formatted pallet name changes in events

* chore: formatted pallet name changes in events

* chore: formatted pallet name changes in events

* chore: formatted pallet name changes in events

* chore: formatted pallet name changes in events

* fix: add fix to tests for event variants

* chore: modified comments for event variants

* chore: modified comments for event variants

* chore: modified comments for event variants

* chore: modified comments for event variants

* chore: modified system pallet event variants

* chore: modified system pallet event variants

* chore: modified system pallet event variants

* chore: modified system pallet event variants

* chore: modified system pallet event variants

* chore: modified system pallet event variants

* chore: modified system pallet event variants

* chore: modified system pallet event variants

* chore: modified system pallet event variants

* chore: updated transaction-storage pallet event variants

* chore: updated transaction-storage pallet event variants

* chore: formatted contracts pallet

* chore: update treasury event variants
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants