Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

tuple to struct event variants #10206

Merged
merged 14 commits into from
Nov 11, 2021
Merged

tuple to struct event variants #10206

merged 14 commits into from
Nov 11, 2021

Conversation

Doordashcon
Copy link
Contributor

@Doordashcon Doordashcon commented Nov 6, 2021 •
edited
Loading

This pull request changes the pallet Events variants from tuples to structs with named fields.

Part implementation for #9903, #9993 & #10184

Pallets with changes

  • sudo
  • tips

polkadot address: 12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Nov 6, 2021

User @Doordashcon, please sign the CLA here.

@Doordashcon Doordashcon marked this pull request as ready for review November 6, 2021 12:55
@shawntabrizi
Copy link
Member

/tip small

@substrate-tip-bot
Copy link

Please fix the following problems before calling the tip bot again:

  • Contributor did not properly post their Polkadot or Kusama address. Make sure the pull request has: "{network} address: {address}".

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Nov 8, 2021
@Doordashcon
Copy link
Contributor Author

{polkadot} address: {12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h}

@KiChjang
Copy link
Contributor

KiChjang commented Nov 9, 2021

@Doordashcon you need to put it in your PR description, not as a comment. I've edited your PR post to include your DOT address. Also take note of the format, i.e. no braces are required.

@KiChjang KiChjang added the A0-please_review Pull request needs code review. label Nov 9, 2021
@Doordashcon
Copy link
Contributor Author

Doordashcon commented Nov 11, 2021 •
edited
Loading

/tip small

Thanks for the tip, PR updated

@shawntabrizi
Copy link
Member

/tip small

@substrate-tip-bot
Copy link

A small tip was successfully submitted for Doordashcon (12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h on polkadot).

https://polkadot.js.org/apps/#/treasury/tips

@KiChjang
Copy link
Contributor

Need to run cargo +nightly fmt.

@KiChjang KiChjang added A8-mergeoncegreen and removed A0-please_review Pull request needs code review. labels Nov 11, 2021
@KiChjang
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 5d22361 into paritytech:master Nov 11, 2021
@xlc
Copy link
Contributor

xlc commented Nov 12, 2021

Do we know if this is going to cause any compatibility concerns on client side?

ordian added a commit that referenced this pull request Nov 12, 2021
@ordian
Merge branch 'master' into 3x8_update_nightly_fix_fmt
5cf1cc8 
* master: (27 commits)
  Bump rustversion from 1.0.4 to 1.0.5 (#10243)
  Kill the light client, CHTs and change tries. (#10080)
  tuple to struct event variants (#10206)
  Bump thiserror from 1.0.26 to 1.0.30 (#10240)
  Warn about usage of pallet collective set members call. (#10156)
  Bump git2 from 0.13.22 to 0.13.23 (#10238)
  Add group name in task metrics  (#10196)
  Bump proc-macro-crate from 1.0.0 to 1.1.0 (#10237)
  Bump parity-util-mem from 0.10.0 to 0.10.2 (#10236)
  Bump substrate-bip39 from 0.4.2 to 0.4.4 (#10213)
  Upgrade jsonrpsee to v0.4.1 (#10022)
  expose substrate-cli service (#10229)
  Intend to reactivate cargo-unleash check (#10167)
  CI: build docs with deps (#9884)
  use CountedMap in pallet-bags-list (#10179)
  Move all example pallets under `examples` folder. (#10215)
  Upgrade wasm builder (#10226)
  upgrade ss58-registry with additional networks. (#10224)
  move wiki -> docs (#10225)
  new remote-ext mode: (#10192)
  ...
@Doordashcon Doordashcon deleted the ddc-AFNPEV-T2 branch November 12, 2021 20:57
@Doordashcon Doordashcon mentioned this pull request Nov 13, 2021
Merged
@athei athei mentioned this pull request Nov 15, 2021
Merged
@ECJ222 ECJ222 mentioned this pull request Nov 17, 2021
Merged
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
@Doordashcon @shawntabrizi @grishasobol
tuple to struct event variants (paritytech#10206)
7454b45 
* update sudo pallet

* Update mock.rs

* cargo +nightly fmt

* frame-support remote-externalities

* AFNPEV tips

* AFNPEV bin & update sudo

* cargo +nightly fmt

* optional dependency remote-test feature

* fmt

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
@Doordashcon Doordashcon mentioned this pull request Sep 29, 2022
Merged
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@Doordashcon @shawntabrizi @ark0f
tuple to struct event variants (paritytech#10206)
fdd87ba 
* update sudo pallet

* Update mock.rs

* cargo +nightly fmt

* frame-support remote-externalities

* AFNPEV tips

* AFNPEV bin & update sudo

* cargo +nightly fmt

* optional dependency remote-test feature

* fmt

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@KiChjang KiChjang KiChjang approved these changes

@andresilva andresilva Awaiting requested review from andresilva

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Doordashcon @shawntabrizi @KiChjang @xlc