Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Intend to reactivate cargo-unleash check #10167

Merged
merged 22 commits into from
Nov 10, 2021
Merged

Conversation

gnunicorn
Copy link
Contributor

@gnunicorn gnunicorn commented Nov 3, 2021

It appears the bug it was deactivated for has been resolved a while ago. Trying to reactivate the checks.

polkadot companion: paritytech/polkadot#4257
cumulus companion: paritytech/cumulus#730

It appears the bug it was deactivated for has been resolved a while ago. Trying to reactivate the checks.
@gnunicorn gnunicorn requested a review from a team as a code owner November 3, 2021 12:13
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Nov 3, 2021
@gnunicorn gnunicorn added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Nov 3, 2021
@gnunicorn gnunicorn requested a review from adoerr as a code owner November 3, 2021 14:56
@adoerr adoerr added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Nov 3, 2021
Copy link
Contributor

@adoerr adoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BEEFY part LGTM

Copy link
Contributor

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TriplEight
Copy link
Contributor

I think this needs a rebase.

@gnunicorn
Copy link
Contributor Author

gnunicorn commented Nov 4, 2021

well, this is a mess again. It looks like someone (outside our company) has published a -dev-versioned, broken crate of ours to crates.io – and now cargo unleash (appropriately) picks that and as a result the publishing test fails. Gotta sleep over what to do about this now...

@gnunicorn gnunicorn marked this pull request as draft November 4, 2021 19:10
@gnunicorn gnunicorn marked this pull request as ready for review November 5, 2021 10:51
@gnunicorn gnunicorn requested a review from tomusdrw as a code owner November 8, 2021 08:31
@TriplEight
Copy link
Contributor

@gnunicorn what's the plan on removing the allow_failure: true, is it stable enough?

@gnunicorn
Copy link
Contributor Author

I think so, @TriplEight . But it still takes quite a while and with certain improvements to the test, this might be blocking longer than necessary....

ordian added a commit that referenced this pull request Nov 12, 2021
* master: (27 commits)
  Bump rustversion from 1.0.4 to 1.0.5 (#10243)
  Kill the light client, CHTs and change tries. (#10080)
  tuple to struct event variants (#10206)
  Bump thiserror from 1.0.26 to 1.0.30 (#10240)
  Warn about usage of pallet collective set members call. (#10156)
  Bump git2 from 0.13.22 to 0.13.23 (#10238)
  Add group name in task metrics  (#10196)
  Bump proc-macro-crate from 1.0.0 to 1.1.0 (#10237)
  Bump parity-util-mem from 0.10.0 to 0.10.2 (#10236)
  Bump substrate-bip39 from 0.4.2 to 0.4.4 (#10213)
  Upgrade jsonrpsee to v0.4.1 (#10022)
  expose substrate-cli service (#10229)
  Intend to reactivate cargo-unleash check (#10167)
  CI: build docs with deps (#9884)
  use CountedMap in pallet-bags-list (#10179)
  Move all example pallets under `examples` folder. (#10215)
  Upgrade wasm builder (#10226)
  upgrade ss58-registry with additional networks. (#10224)
  move wiki -> docs (#10225)
  new remote-ext mode: (#10192)
  ...
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
* Intend to reactivate cargo-unleash check

It appears the bug it was deactivated for has been resolved a while ago. Trying to reactivate the checks.

* adding missing cargo.toml metadata for BEEFY crates

* fix wrong version reference

* matching up versions

* disable faulty cache

* switching more versions to prerelease

* Revert "disable faulty cache"

This reverts commit 411a12a.

* bump minor of sc-allocator to fix already-published-issue

* fixup another pre-released dependency problem

* temp switch to latest unleash

* fixing dependency version and features

* prometheus endpoint has also been changed

* fixing proposer metrics versioning

* fixing hex feature for beefy

* fix generate-bags feature selection

* fixup Cargo.lock

* upgrade prometheus dependencies

* missed one

* switch to latest release
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* Intend to reactivate cargo-unleash check

It appears the bug it was deactivated for has been resolved a while ago. Trying to reactivate the checks.

* adding missing cargo.toml metadata for BEEFY crates

* fix wrong version reference

* matching up versions

* disable faulty cache

* switching more versions to prerelease

* Revert "disable faulty cache"

This reverts commit 411a12a.

* bump minor of sc-allocator to fix already-published-issue

* fixup another pre-released dependency problem

* temp switch to latest unleash

* fixing dependency version and features

* prometheus endpoint has also been changed

* fixing proposer metrics versioning

* fixing hex feature for beefy

* fix generate-bags feature selection

* fixup Cargo.lock

* upgrade prometheus dependencies

* missed one

* switch to latest release
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants