This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Move all example pallets under examples folder.
#10215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
jimmychu0807
added
B0-silent
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
jimmychu0807
added
the
D3-trivial 🧸
bkchr
reviewed
Nov 8, 2021
| "frame/example-parallel", | ||
| "frame/examples/basic", | ||
| "frame/examples/offchain-worker", | ||
| "frame/examples/parallel", |
There was a problem hiding this comment.
Can we add some information that this is highly experimental and not really supported? Maybe in the crate level docs?
There was a problem hiding this comment.
I updated with a note that these example pallets are not meant to be used in production in this commit.
Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
bkchr
approved these changes
Nov 9, 2021
TriplEight
approved these changes
Nov 9, 2021
apopiak
approved these changes
Nov 9, 2021
|
I don't have right to merge the pull request and will need one of you to merge this PR @bkchr @apopiak @TriplEight . Thanks. |
|
bot merge |
|
Like it! Although @jimmychu0807 you broke doc links FYI - we should be aware that moving things around might do this in docs - the devhub CI will quickly spot it, but as a |
|
dumb q: are these pallets tested in CI at this level of the directory structure? |
ordian
added a commit
that referenced
this pull request
Nov 12, 2021
* master: (27 commits) Bump rustversion from 1.0.4 to 1.0.5 (#10243) Kill the light client, CHTs and change tries. (#10080) tuple to struct event variants (#10206) Bump thiserror from 1.0.26 to 1.0.30 (#10240) Warn about usage of pallet collective set members call. (#10156) Bump git2 from 0.13.22 to 0.13.23 (#10238) Add group name in task metrics (#10196) Bump proc-macro-crate from 1.0.0 to 1.1.0 (#10237) Bump parity-util-mem from 0.10.0 to 0.10.2 (#10236) Bump substrate-bip39 from 0.4.2 to 0.4.4 (#10213) Upgrade jsonrpsee to v0.4.1 (#10022) expose substrate-cli service (#10229) Intend to reactivate cargo-unleash check (#10167) CI: build docs with deps (#9884) use CountedMap in pallet-bags-list (#10179) Move all example pallets under `examples` folder. (#10215) Upgrade wasm builder (#10226) upgrade ss58-registry with additional networks. (#10224) move wiki -> docs (#10225) new remote-ext mode: (#10192) ...
|
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Put all examples under one folder Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com> * Updated Cargo.toml Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com> * updated for ci script Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com> * update Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com> * Added notes that example pallets are not meant to be used in production. Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com> * updated Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Put all examples under one folder Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com> * Updated Cargo.toml Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com> * updated for ci script Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com> * update Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com> * Added notes that example pallets are not meant to be used in production. Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com> * updated Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a pretty trivial update.