-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add batch calls example #303
Add batch calls example #303
Conversation
Aj metadata vnext
Aj metadata vnext
fix metadata constants (paritytech#299)
Aj metadata vnext
Aj metadata vnext
.to_runtime_api::<polkadot::RuntimeApi<polkadot::DefaultConfig>>(); | ||
|
||
let calls = vec![ | ||
Call::Balances(BalancesCall::transfer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's worth noting that this depends on the target runtime pallets having the same indices as that of the static metadata used to generate the API. When running a single call we dynamically add the index prefix based on the metadata fetched at runtime.
We probably need some mechanism to compare the static metadata used to generate the API with the metadata fetched from the node at runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's worth noting that this depends on the target runtime pallets having the same indices as that of the static metadata used to generate the API. When running a single call we dynamically add the index prefix based on the metadata fetched at runtime.
We probably need some mechanism to compare the static metadata used to generate the API with the metadata fetched from the node at runtime.
@ascjones I assume the same is true for the sudo
wrapper? With both of these calls, I get panicked at Bad input data provided to validate_transaction: Codec error
. Is this the error you would expect when there is an index mismatch? The strange thing is, though, that I get this error despite the fact the both the static and dynamic metadata are generated by the same binary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we would, it means the call can't be decoded which means we are encoding it wrong. I am vaguely aware that sudo
calls are handled slightly differently, so the autogenerated types might not work for this pallet. It needs looking into - I won't have time this week since I'm away. A clue is to look how it was handled here previously, with a raw encoded call: https://github.com/paritytech/subxt/blob/master/src/frame/sudo.rs#L37
Aj metadata vnext
Aj metadata vnext
Aj metadata vnext
Aj metadata vnext
Sorry this pull request was not meant to be closed. It should have been created from a different branch on my forked repo. @ascjones yes, in the previous version i was just encoding the calls and push them into a I think will be nice for this repo to have a batch call example, I'll try to submit a new pull request. |
You can now do a PR against |
No description provided.