Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch calls example #303

Closed
74 changes: 74 additions & 0 deletions examples/batch_calls.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
// Copyright 2019-2021 Parity Technologies (UK) Ltd.
// This file is part of subxt.
//
// subxt is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// subxt is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with subxt. If not, see <http://www.gnu.org/licenses/>.

//! To run this example, a local polkadot node should be running.
//!
//! E.g.
//! ```bash
//! curl "https://github.com/paritytech/polkadot/releases/download/v0.9.11/polkadot" --output /usr/local/bin/polkadot --location
//! polkadot --dev --tmp
//! ```

use sp_keyring::AccountKeyring;
use subxt::{ClientBuilder, PairSigner};

#[subxt::subxt(runtime_metadata_path = "examples/polkadot_metadata.scale")]
pub mod polkadot {}

type Call = polkadot::runtime_types::polkadot_runtime::Call;
type BalancesCall = polkadot::runtime_types::pallet_balances::pallet::Call;

#[async_std::main]
async fn main() -> Result<(), Box<dyn std::error::Error>> {
env_logger::init();

let alice = PairSigner::new(AccountKeyring::Alice.pair());
let bob = AccountKeyring::Bob.to_account_id().into();
let charlie = AccountKeyring::Charlie.to_account_id().into();

let api = ClientBuilder::new()
.build()
.await?
.to_runtime_api::<polkadot::RuntimeApi<polkadot::DefaultConfig>>();

let calls = vec![
Call::Balances(BalancesCall::transfer {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth noting that this depends on the target runtime pallets having the same indices as that of the static metadata used to generate the API. When running a single call we dynamically add the index prefix based on the metadata fetched at runtime.

We probably need some mechanism to compare the static metadata used to generate the API with the metadata fetched from the node at runtime.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth noting that this depends on the target runtime pallets having the same indices as that of the static metadata used to generate the API. When running a single call we dynamically add the index prefix based on the metadata fetched at runtime.

We probably need some mechanism to compare the static metadata used to generate the API with the metadata fetched from the node at runtime.

@ascjones I assume the same is true for the sudo wrapper? With both of these calls, I get panicked at Bad input data provided to validate_transaction: Codec error. Is this the error you would expect when there is an index mismatch? The strange thing is, though, that I get this error despite the fact the both the static and dynamic metadata are generated by the same binary

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we would, it means the call can't be decoded which means we are encoding it wrong. I am vaguely aware that sudo calls are handled slightly differently, so the autogenerated types might not work for this pallet. It needs looking into - I won't have time this week since I'm away. A clue is to look how it was handled here previously, with a raw encoded call: https://github.com/paritytech/subxt/blob/master/src/frame/sudo.rs#L37

dest: bob,
value: 10_000,
}),
Call::Balances(BalancesCall::transfer {
dest: charlie,
value: 5_000,
}),
];

let result = api
.tx()
.utility()
.batch(calls)
.sign_and_submit_then_watch(&alice)
.await
.unwrap();

if let Some(event) =
result.find_event::<polkadot::utility::events::BatchCompleted>()?
{
println!("Batch success: value: {:?}", event);
} else {
println!("Failed to find Utility::BatchCompleted Event");
}
Ok(())
}