Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update substrate crates #709

Merged
merged 17 commits into from
Nov 16, 2022
Merged

Update substrate crates #709

merged 17 commits into from
Nov 16, 2022

Conversation

ascjones
Copy link
Contributor

@ascjones ascjones commented Nov 9, 2022

Update to latest releases 7.0.0 of substrate crates

@ascjones ascjones changed the title Update substrate dependencies, removing parity-util-mem transitive dependency Update substrate dependencies, no more parity-util-mem Nov 9, 2022
@ascjones ascjones changed the title Update substrate dependencies, no more parity-util-mem Update substrate crates, no more parity-util-mem Nov 9, 2022
@niklasad1
Copy link
Member

@ascjones

use default features for sp-runtime again implies that we will have parity-util-mem in the dependency tree? 😵‍💫

@ascjones
Copy link
Contributor Author

ascjones commented Nov 14, 2022

use default features for sp-runtime again implies that we will have parity-util-mem in the dependency tree? face_with_spiral_eyes

Sadly it seems that way. The issue seems to be that the std feature of sp-runtime ensures sp-io/std is used. If it is not then you get all the no_std wasm stuff.

image

So we need to use a dependency feature for parity-util-mem instead of std, or go the whole hog and remove the parity-util-mem entirely: paritytech/substrate#12658

@niklasad1
Copy link
Member

niklasad1 commented Nov 14, 2022

All right, I guess it's worth waiting for paritytech/substrate#12658 before doing a new sp-core release then?

@ascjones
Copy link
Contributor Author

ascjones commented Nov 14, 2022

All right, I guess it's worth waiting for paritytech/substrate#12658 before doing a new sp-core release then?

I think so.

From my side we are planning a new ink 4.0-beta releases this week which would require a new cargo-contract release which depends on both sp-runtime/core and subxt. However for the sake of expediency we may have to require to install from github rather than crates.io.

@ascjones ascjones changed the title Update substrate crates, no more parity-util-mem Update substrate crates Nov 15, 2022
@ascjones ascjones marked this pull request as ready for review November 16, 2022 10:13
examples/Cargo.toml Outdated Show resolved Hide resolved
@niklasad1 niklasad1 merged commit 389f20f into master Nov 16, 2022
@niklasad1 niklasad1 deleted the aj/update-substrate-crates branch November 16, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants