Fix E2E tests by updating Weight type
#1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't the call sides need to be fixed now that the tests are required to pass |
The changes here already change the call argument to |
|
Was thinking about the actual tests in examples which might pass |
|
An auto dry run is performed rather than the user supplying it as a parameter https://github.com/paritytech/ink/blob/66c05c9b0a9139990fc2ac8e81090f668ea9e053/crates/e2e/src/client.rs#L574 |
athei
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sp_weights::Weighttype forgas_limit.sp-coreetc andsubxtSince the e2e test crate is already using
gitdependencies and is not currently released tocrates.io, I am happy to convert the substrate crate dependencies to git. Once all dependencies are released to crates.io we can use those, and then this crate can be released.