-
-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new ParseFile download api #113
Add new ParseFile download api #113
Conversation
e25570a
to
9d6163b
Compare
*/ | ||
@Override | ||
public void done(File file, ParseException e); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline
Some nits and a thought Q Do you think the I think we should update the getData:
getDataStream:
|
For |
/** | ||
* Synchronously gets the file pointer from cache if available or fetches its content from the | ||
* network. You probably want to use {@link #getFileInBackground()} instead unless you're already | ||
* in a background thread. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add the following:
<strong>Note: </strong> The {@link File} location may change without notice and should not be stored to be accessed later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
d6c28b1
to
4181900
Compare
LGTM, feel free to squash and merge! |
4181900
to
831fbbe
Compare
…ownload_file_stream_api Add new ParseFile download api
@wangmengyan95 updated the pull request. |
Support fetch a ParseFile as File pointer or InputStream.
File related new apis:
public File getFile() throws ParseException
public Task<File> getFileInBackground(final ProgressCallback progressCallback)
public Task<File> getFileInBackground()
public void getFileInBackground(GetFileCallback fileCallback, final ProgressCallback progressCallback)
public void getFileInBackground(GetFileCallback fileCallback)
DataStream related new apis:
public File getDataStream() throws ParseException
public Task<File> getDataStreamInBackground(final ProgressCallback progressCallback)
public Task<File> getDataStreamInBackground()
public void getDataStreamInBackground(GetDataStreamCallback fileCallback, final ProgressCallback progressCallback)
public void getDataStreamInBackground(GetDataStreamCallback fileCallback)