Remove ParseFile in memory cache #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangmengyan95
force-pushed
the
wangmengyan.t8120706_remove_ParseFile_in_memory_cache
branch
from
8a1b74a to
6bdaf56
Compare
|
@wangmengyan95 updated the pull request. |
| @@ -58,31 +58,28 @@ public void testConstructor() throws Exception { | |||
| String contentType = "content_type"; | |||
| File file = temporaryFolder.newFile(name); | |||
|
|
|||
| // TODO(mengyan): Test data and file pointer in ParseFile when we have proper stage strategy | |||
There was a problem hiding this comment.
s/stage/staging/g
Could you elaborate on this TODO?
|
Do we have any unit tests to ensure |
|
@wangmengyan95 updated the pull request. |
|
LGTM, feel free to squash and merge! |
wangmengyan95
force-pushed
the
wangmengyan.t8120706_remove_ParseFile_in_memory_cache
branch
from
4dbd847 to
31da68c
Compare
wangmengyan95
added a commit
that referenced
this pull request
Nov 11, 2015
…e_ParseFile_in_memory_cache Remove ParseFile in memory cache
wangmengyan95
deleted the
wangmengyan.t8120706_remove_ParseFile_in_memory_cache
branch
|
@wangmengyan95 updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the in-memory cache for ParseFile. Relies on #113 and #115.