Add new ParseFile constructors and update save method #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangmengyan95
changed the title
This was referenced Sep 9, 2015
| * @param contentType | ||
| * The file's content type. | ||
| */ | ||
| public ParseFile(String name, File file, String contentType) { |
There was a problem hiding this comment.
Is there any real reason we need to pass in name since we can get it from File#getName()?
/cc @nlutsenko since it looks like we have this constructor on iOS.
There was a problem hiding this comment.
We don't have this constructor on iOS.
Simply fileWithContentsAtPath:, since you are right - we can get the file name by using the last path component.
|
Passing to @nlutsenko for API discussion |
|
Let's keep the constructors to just the following:
We can determine |
|
Will revise the constructor. I forget we can get the name from file:( |
|
LGTM, one nit |
wangmengyan95
force-pushed
the
wangmengyan.t8120706_add_upload_file_stream_api
branch
from
632df8d to
cbdf919
Compare
wangmengyan95
added a commit
that referenced
this pull request
Sep 22, 2015
…pload_file_stream_api Add new ParseFile constructors and update save method
wangmengyan95
deleted the
wangmengyan.t8120706_add_upload_file_stream_api
branch
|
@wangmengyan95 updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support creating a ParseFile with File.
New apis:
public ParseFile(String name, File file, String contentType)public ParseFile(File file)public ParseFile(String name, File file)public ParseFile(File file, String contentType)Update
saveAsync()to support upload with a File pointer.