Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add pub publish --dry-run for Flutter package #848

Merged
merged 1 commit into from
Mar 18, 2023

Conversation

Nidal-Bakir
Copy link
Member

New Pull Request Checklist

Issue Description

Closes: #847

Approach

start a job to check for any errors when running dart pub publish --dry-run For the Flutter package

TODOs before merging

Merge this PR first #846

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (94be044) 16.36% compared to head (3128436) 16.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #848   +/-   ##
=======================================
  Coverage   16.36%   16.36%           
=======================================
  Files          47       47           
  Lines        2902     2902           
=======================================
  Hits          475      475           
  Misses       2427     2427           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nidal-Bakir Nidal-Bakir added type:feature New feature or improvement of existing feature type:ci CI related issue labels Mar 7, 2023
@parse-github-assistant
Copy link

The label type:feature cannot be used here.

@parse-github-assistant parse-github-assistant bot removed the type:feature New feature or improvement of existing feature label Mar 7, 2023
@parse-github-assistant
Copy link

The label type:ci cannot be used here.

@parse-github-assistant parse-github-assistant bot removed the type:ci CI related issue label Mar 7, 2023
@Nidal-Bakir Nidal-Bakir added the type:ci CI related issue label Mar 7, 2023
@parse-github-assistant
Copy link

The label type:ci cannot be used here.

@parse-github-assistant parse-github-assistant bot removed the type:ci CI related issue label Mar 7, 2023
@mtrezza
Copy link
Member

mtrezza commented Mar 7, 2023

@Nidal-Bakir just to explain the bot, most labels incl. type: can only be used on issues.

@Nidal-Bakir
Copy link
Member Author

@mtrezza

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 5536fc1 into parse-community:master Mar 18, 2023
@mtrezza
Copy link
Member

mtrezza commented Mar 18, 2023

@nidal, it seems this CI addition also fails in #846, so another fix may be needed, could you look into this?

@Nidal-Bakir Nidal-Bakir mentioned this pull request Mar 18, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Check for pub publish --dry-run errors for the Flutter package
2 participants