Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Rename Flutter package source file to parse_server_sdk_flutter.dart #846

Merged
merged 8 commits into from
Mar 18, 2023
Merged

feat: Rename Flutter package source file to parse_server_sdk_flutter.dart #846

merged 8 commits into from
Mar 18, 2023

Conversation

Nidal-Bakir
Copy link
Member

New Pull Request Checklist

Issue Description

Closes: #845

Approach

Rename the Flutter package source

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry

@parse-github-assistant
Copy link

parse-github-assistant bot commented Mar 7, 2023 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@Nidal-Bakir Nidal-Bakir added the state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message label Mar 7, 2023
@Nidal-Bakir Nidal-Bakir changed the title feat!: Rename the source file for Flutter package feat: Rename the source file for Flutter package Mar 7, 2023
@Nidal-Bakir Nidal-Bakir requested a review from mtrezza March 7, 2023 17:41
@codecov
Copy link

codecov bot commented Mar 7, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (23118dd) 26.35% compared to head (1148caf) 26.35%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #846   +/-   ##
=======================================
  Coverage   26.35%   26.35%           
=======================================
  Files          47       47           
  Lines        2903     2903           
=======================================
  Hits          765      765           
  Misses       2138     2138
Impacted Files Coverage Δ
packages/flutter/lib/parse_server_sdk_flutter.dart 8.77% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nidal-Bakir Nidal-Bakir mentioned this pull request Mar 7, 2023
Merged
5 tasks
@Nidal-Bakir
revert: the last two commits conflict with PR parse-community#844
ff38685 
Revert "bump dependencies versions for the Flutter package"

Revert "chore: bump the flutter sdk version to 4.0.0 and add change log entry"

This reverts commit
67d9512
dae1d47
@Nidal-Bakir
chore: bump the flutter sdk version to 4.0.0 and add change log entry
5760a9b
mbfakourii
mbfakourii previously approved these changes Mar 9, 2023
View reviewed changes
@mtrezza
Copy link
Member

mtrezza commented Mar 9, 2023

Maybe let's wait to resolve #850. In case the decision is made to merge the packages, both breaking changes may be combined into one.

@mtrezza mtrezza mentioned this pull request Mar 10, 2023
Closed
4 tasks
@Nidal-Bakir
Copy link
Member Author

@mtrezza
this

@Nidal-Bakir
Copy link
Member Author

Nidal-Bakir commented Mar 18, 2023 •
edited
Loading

Flutter dry-run will fail ci / publish dry-run (flutter) (pull_request) because this PR is not merged yet.

mtrezza
mtrezza reviewed Mar 18, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please review the modified changelog entry, whether it's correct?

@Nidal-Bakir
Copy link
Member Author

Yes, it is all correct.

@mtrezza mtrezza changed the title feat: Rename the source file for Flutter package feat: Rename Flutter package source file to parse_server_sdk_flutter.dart Mar 18, 2023
mtrezza
mtrezza approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@mtrezza mtrezza merged commit 9bde626 into parse-community:master Mar 18, 2023
@Nidal-Bakir
Copy link
Member Author

Nidal-Bakir commented Mar 18, 2023 •
edited
Loading

@mtrezza

ci / publish dry-run (flutter) (pull_request)

Because parse_server_sdk_flutter depends on flutter_test from sdk which doesn't exist (the Flutter SDK is not available), version solving failed.

I will fix this in new PR. it is because the ci job installs dart SDK and not flutter. and we need Flutter for testing.

This was referenced Mar 18, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

@mbfakourii mbfakourii mbfakourii left review comments

Assignees
No one assigned
Labels
state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flutter package uses a name for the source file that is different from the package name
3 participants
@Nidal-Bakir @mtrezza @mbfakourii