Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for the LDAP auth module #685

Merged
merged 5 commits into from
Jan 9, 2020
Merged

Add documentation for the LDAP auth module #685

merged 5 commits into from
Jan 9, 2020
+68 −17

Conversation

brodo
Copy link
Contributor

@brodo brodo commented Nov 20, 2019

This PR adds documentation for the LDAP auth module.

@brodo @TomWFox
fix typo in LDAP auth module
b6e7344 
Co-Authored-By: Tom Fox <13188249+TomWFox@users.noreply.github.com>
dplewis
dplewis suggested changes Nov 20, 2019
View reviewed changes
_includes/parse-server/third-party-auth.md Outdated Show resolved Hide resolved
_includes/parse-server/third-party-auth.md Outdated Show resolved Hide resolved
_includes/parse-server/third-party-auth.md Outdated Show resolved Hide resolved
TomWFox
TomWFox approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! As standard we’ll wait until the server pr is merged and a release is published before merging the docs pr.

@brodo
Copy link
Contributor Author

brodo commented Nov 26, 2019

The PR in the other repo is merged now.

@TomWFox
Copy link
Contributor

TomWFox commented Nov 26, 2019

👍 I’ll wait for a release to merge this.

@TomWFox
Copy link
Contributor

TomWFox commented Jan 9, 2020

@brodo could you resolve the merge conflict and then we'll get this in

@dplewis dplewis requested a review from TomWFox January 9, 2020 22:05
@dplewis dplewis merged commit 38ba0f6 into parse-community:gh-pages Jan 9, 2020
@TomWFox
Copy link
Contributor

TomWFox commented Jan 9, 2020

Thanks @dplewis :)

@TomWFox TomWFox removed their request for review January 9, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomWFox TomWFox TomWFox approved these changes

@dplewis dplewis dplewis approved these changes

Assignees
No one assigned
Labels
docs:server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brodo @TomWFox @dplewis