Add LDAP auth module #6226
Merged
Add LDAP auth module #6226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodo
force-pushed
the
ldap-auth-support
branch
from
feec168 to
3017ef2
Compare
Codecov Report
@@ Coverage Diff @@
## master #6226 +/- ##
==========================================
- Coverage 93.85% 93.78% -0.07%
==========================================
Files 167 168 +1
Lines 11302 11344 +42
==========================================
+ Hits 10607 10639 +32
- Misses 695 705 +10
Continue to review full report at Codecov.
|
|
I don't know why Codecov thinks coverage in files which I did not touch has decreased. 😐 |
brodo
force-pushed
the
ldap-auth-support
branch
from
3017ef2 to
b2ed290
Compare
dplewis
suggested changes
Nov 22, 2019
There was one more place where I forgot the destroy/unbind. Should be all fixed now. |
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a auth module for LDAP servers. There are some people who have rolled their own implementations of this (you can find them by searching for 'ldap' in the issues) so there is definitely a need for it. The PR adds a dependency on the ldapjs package.
I tried to make it as generic as possible, so it should work with all kinds of LDAP servers and configurations. This means that it takes a lot of config options, but I'll open a PR in the
docsrepo shortly where I describe how to set it up.