Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add masterkey parameters #1233

Merged

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Aug 20, 2019

Adds a property to Parse Config parameter to make it only retrievable with master key.

@mtrezza
Copy link
Member Author

mtrezza commented Aug 20, 2019

This feature requires parse-community/parse-server#5954.

@davimacedo
Copy link
Member

davimacedo commented Aug 21, 2019

@mtrezza nice job! Could you please just centralize the field and set the background color to the same of the other fields? Below how it currently is:
Screen Shot 2019-08-20 at 11 12 41 PM

It would be good if it had the same style of the other similar fields. An example below:
Screen Shot 2019-08-20 at 11 14 24 PM

@davimacedo
Copy link
Member

Also.. in the other places this field is used the labels are No and Yes

@mtrezza
Copy link
Member Author

mtrezza commented Aug 21, 2019

@davimacedo Done, looks like this now:

Screen Shot 2019-08-21 at 12 15 47

Co-Authored-By: Tom Fox <tomfox@surprises.io>
@TomWFox
Copy link
Contributor

TomWFox commented Aug 21, 2019

Could you check that the text is displayed correctly with the extra words?

@mtrezza
Copy link
Member Author

mtrezza commented Aug 21, 2019

Actually I am thinking about adding a parse server version check for that new property. So the dashboard doesn’t show the field when the server doesn’t support it.

@davimacedo which parse server version should I add as the minimum? 3.7.3?

@TomWFox
Copy link
Contributor

TomWFox commented Aug 21, 2019

Lots of changes for the next release so it should be 3.8.0

@mtrezza
Copy link
Member Author

mtrezza commented Aug 21, 2019

Could you check that the text is displayed correctly with the extra words?

Yes, text fits.

@mtrezza
Copy link
Member Author

mtrezza commented Aug 21, 2019

All changes done, ready for merge I believe.

@TomWFox TomWFox requested review from davimacedo and dplewis August 21, 2019 15:53
@davimacedo
Copy link
Member

@dplewis do you want to take a look as well?

@davimacedo davimacedo merged commit 7260816 into parse-community:master Aug 22, 2019
@mtrezza mtrezza deleted the add_masterkeyonly_parameter branch September 2, 2019 16:27
@mtrezza
Copy link
Member Author

mtrezza commented Sep 3, 2019

@davimacedo This feature has been released with parse server 3.8. Can you create a dashboard release so the feature can be used, since there are also no open dashboard PRs?

@davimacedo
Copy link
Member

I've just sent the PR for the new version: https://github.com/parse-community/parse-dashboard/pull/1263/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants