Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added section about master key config #667

Merged

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Aug 20, 2019

No description provided.

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow fast, I love when the docs are ready even before the feature has been merged or released!

I think a bit of rewording is needed here, we'll wait to merge this until the relevant PRs have been merged and releases made.

_includes/cloudcode/cloud-code-advanced.md Outdated Show resolved Hide resolved
@mtrezza
Copy link
Member Author

mtrezza commented Aug 20, 2019

Requires parse-community/parse-server#5954 and parse-community/parse-dashboard#1233 to be released.

Co-Authored-By: Tom Fox <tomfox@surprises.io>
@mtrezza
Copy link
Member Author

mtrezza commented Sep 3, 2019

Don't merge yet, I think some changes need to be made in the JS SDK as well. Discussion in parse-community/parse-server#5930

mtrezza and others added 6 commits September 6, 2019 14:11
* commit 'e129790ed587819ecfcaed59fc7ff90ec6ffcfa1': (84 commits)
  Add `cascadeSave` option in ParseObject to JS docs (parse-community#664)
  Update apple sign in documentation (parse-community#662)
  Bump mixin-deep from 1.3.1 to 1.3.2 (parse-community#670)
  Update GraphQL docs with latest changes (parse-community#669)
  remove a bunch of parse cloud references (parse-community#654)
  docs: fixed examples for pipeline in aggregation (parse-community#661)
  Add beta notice to the GraphQL Guide (parse-community#659)
  iOS Documentation Revamp (parse-community#650)
  Fix doc for creating a subscription in javascript (parse-community#658)
  GraphQL Customisation (parse-community#652)
  added PhantAuth authData docs (parse-community#655)
  Fix typo in keys.md (parse-community#656)
  Fix typo in cloud-code.md (parse-community#657)
  add reference to afterFind, add more detail on predefined classes (parse-community#653)
  Add `keys` and `excludeKeys` options to REST docs (parse-community#649)
  document push type and priority keys for notifications (parse-community#639)
  Documentation for Sign In With Apple (parse-community#648)
  Documentation for isDataAvailable (parse-community#647)
  Remove line for 3.x (parse-community#646)
  Add documentation for query.withCount (parse-community#645)
  ...
Co-Authored-By: Tom Fox <tomfox@surprises.io>
…trezza/docs into add_cloudcode_masterkey_config

* 'add_cloudcode_masterkey_config' of https://github.com/mtrezza/docs:
  updated field wording according to dashboard
  Update _includes/cloudcode/cloud-code-advanced.md
  added section about master key config
@mtrezza
Copy link
Member Author

mtrezza commented Sep 6, 2019

I've added docs for parse-community/Parse-SDK-JS#910 after changes have been approved. Will that be merged as well or is there another approval round needed?

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@mtrezza mtrezza closed this Sep 6, 2019
@mtrezza mtrezza deleted the add_cloudcode_masterkey_config branch September 6, 2019 14:43
@mtrezza mtrezza restored the add_cloudcode_masterkey_config branch September 6, 2019 14:44
@mtrezza
Copy link
Member Author

mtrezza commented Sep 6, 2019

Oops, I just deleted the branch by mistake. What should I do now, open a new PR?

@mtrezza mtrezza reopened this Sep 6, 2019
@mtrezza
Copy link
Member Author

mtrezza commented Sep 6, 2019

Ah, it seems to be fine after reopening.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit 3db2171 into parse-community:gh-pages Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants