fix: Text selection not visible in modal dialog header #2340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
jadsonlourenco
changed the title
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
mtrezza
changed the title
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
|
You suggested:
Did you try to remove the selection color and let the browser handle this? I would expect a browser to choose a color automatically that makes the selection distinct enough. |
|
Yes, I think this is the solution to this issue. Works correctly in my tests on Chrome, Safari and Firefox. So sorry about the multiple commits, I forgot to remove the commented code. |
|
Perfect, thanks for your PR! |
|
🎉 This change has been released in version 5.1.0-alpha.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Mar 1, 2023
# [5.1.0-beta.2](5.1.0-beta.1...5.1.0-beta.2) (2023-03-01) ### Bug Fixes * Add dashboard option `cookieSessionMaxAge` to keep user logged in across browser sessions ([#2366](#2366)) ([9ea95fc](9ea95fc)) * Blank screen shown if server is unreachable; unsupported pages are accessible via direct URLs ([#2363](#2363)) ([9855258](9855258)) * Dashboard may display blank page when selecting an app after login ([#2375](#2375)) ([f399b91](f399b91)) * Data browser dialog "No data to display" may be outside of visible area in Safari browser ([#2387](#2387)) ([52bba62](52bba62)) * Internal error message on login with missing credential ([#2370](#2370)) ([9a6a31f](9a6a31f)) * Navigation to page fails if user re-login is required ([#2369](#2369)) ([0db6f55](0db6f55)) * Screen goes blank when trying to add column of type `Object` or `GeoPoint` ([#2384](#2384)) ([0886386](0886386)) * Text selection not visible in modal dialog header ([#2340](#2340)) ([fb0e79c](fb0e79c)) ### Features * Add export all rows of a class and export in JSON format ([#2361](#2361)) ([9eb36a1](9eb36a1)) * Add schema export ([#2362](#2362)) ([33df049](33df049))
|
🎉 This change has been released in version 5.1.0-beta.2 |
parseplatformorg
pushed a commit
that referenced
this pull request
May 1, 2023
# [5.1.0](5.0.0...5.1.0) (2023-05-01) ### Bug Fixes * Add dashboard option `cookieSessionMaxAge` to keep user logged in across browser sessions ([#2366](#2366)) ([9ea95fc](9ea95fc)) * Blank screen shown if server is unreachable; unsupported pages are accessible via direct URLs ([#2363](#2363)) ([9855258](9855258)) * Dashboard may display blank page when selecting an app after login ([#2375](#2375)) ([f399b91](f399b91)) * Data browser dialog "No data to display" may be outside of visible area in Safari browser ([#2387](#2387)) ([52bba62](52bba62)) * Internal error message on login with missing credential ([#2370](#2370)) ([9a6a31f](9a6a31f)) * Navigation to page fails if user re-login is required ([#2369](#2369)) ([0db6f55](0db6f55)) * Screen goes blank when trying to add column of type `Object` or `GeoPoint` ([#2384](#2384)) ([0886386](0886386)) * Text selection not visible in modal dialog header ([#2340](#2340)) ([fb0e79c](fb0e79c)) ### Features * Add export all rows of a class and export in JSON format ([#2361](#2361)) ([9eb36a1](9eb36a1)) * Add schema export ([#2362](#2362)) ([33df049](33df049)) * remove limitation to refresh Cloud Jobs list only after 30 seconds ([#2332](#2332)) ([ad1132f](ad1132f))
|
🎉 This change has been released in version 5.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Related issue: #1831
Closes #1831
Approach
TODOs before merging