Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Internal error message on login with missing credential #2370

Merged
merged 5 commits into from
Jan 29, 2023

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jan 25, 2023

New Pull Request Checklist

Issue Description

Passport can throw error strings, which cannot be converted to JSON. In this case, the errors should not be overridden.

Closes: #2367

Approach

TODOs before merging

  • Add tests

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: syntax error on missing credentials fix: Syntax error on missing credentials Jan 25, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 25, 2023

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

src/login/Login.js Outdated Show resolved Hide resolved
@mtrezza mtrezza closed this Jan 27, 2023
@mtrezza mtrezza reopened this Jan 27, 2023
@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Jan 27, 2023

This branch has been deployed using Uffizzi.

Preview URL:
https://pr-2370-deployment-12533-parse-dashboard.app.uffizzi.com

View deployment details here:
https://https://app.uffizzi.com/projects/5259/deployments

This is an automated comment. To turn off commenting, visit uffizzi.com.

@mtrezza mtrezza mentioned this pull request Jan 27, 2023
3 tasks
@mtrezza mtrezza closed this Jan 28, 2023
@mtrezza mtrezza reopened this Jan 28, 2023
@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Jan 28, 2023

This branch has been deployed using Uffizzi.

Preview URL:
https://pr-2370-deployment-12609-parse-dashboard.app.uffizzi.com

View deployment details here:
https://https://app.uffizzi.com/projects/5259/deployments

This is an automated comment. To turn off commenting, visit uffizzi.com.

@mtrezza mtrezza changed the title fix: Syntax error on missing credentials fix: Internal error message on login with missing credentials Jan 28, 2023
Co-authored-by: Manuel <5673677+mtrezza@users.noreply.github.com>
@mtrezza mtrezza closed this Jan 29, 2023
@mtrezza mtrezza reopened this Jan 29, 2023
@mtrezza mtrezza changed the title fix: Internal error message on login with missing credentials fix: Internal error message on login with missing credential Jan 29, 2023
@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Jan 29, 2023

This branch has been deployed using Uffizzi.

Preview URL:
https://pr-2370-deployment-12660-parse-dashboard.app.uffizzi.com

View deployment details here:
https://https://app.uffizzi.com/projects/5259/deployments

This is an automated comment. To turn off commenting, visit uffizzi.com.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested in preview.

@mtrezza mtrezza merged commit 9a6a31f into parse-community:alpha Jan 29, 2023
parseplatformorg pushed a commit that referenced this pull request Jan 29, 2023
# [5.1.0-alpha.8](5.1.0-alpha.7...5.1.0-alpha.8) (2023-01-29)

### Bug Fixes

* Internal error message on login with missing credential ([#2370](#2370)) ([9a6a31f](9a6a31f))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-alpha.8

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 29, 2023
@dblythy dblythy deleted the fix-login branch January 29, 2023 10:53
parseplatformorg pushed a commit that referenced this pull request Mar 1, 2023
# [5.1.0-beta.2](5.1.0-beta.1...5.1.0-beta.2) (2023-03-01)

### Bug Fixes

* Add dashboard option `cookieSessionMaxAge` to keep user logged in across browser sessions ([#2366](#2366)) ([9ea95fc](9ea95fc))
* Blank screen shown if server is unreachable; unsupported pages are accessible via direct URLs ([#2363](#2363)) ([9855258](9855258))
* Dashboard may display blank page when selecting an app after login ([#2375](#2375)) ([f399b91](f399b91))
* Data browser dialog "No data to display" may be outside of visible area in Safari browser ([#2387](#2387)) ([52bba62](52bba62))
* Internal error message on login with missing credential ([#2370](#2370)) ([9a6a31f](9a6a31f))
* Navigation to page fails if user re-login is required ([#2369](#2369)) ([0db6f55](0db6f55))
* Screen goes blank when trying to add column of type `Object` or `GeoPoint` ([#2384](#2384)) ([0886386](0886386))
* Text selection not visible in modal dialog header ([#2340](#2340)) ([fb0e79c](fb0e79c))

### Features

* Add export all rows of a class and export in JSON format ([#2361](#2361)) ([9eb36a1](9eb36a1))
* Add schema export ([#2362](#2362)) ([33df049](33df049))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-beta.2

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Mar 1, 2023
parseplatformorg pushed a commit that referenced this pull request May 1, 2023
# [5.1.0](5.0.0...5.1.0) (2023-05-01)

### Bug Fixes

* Add dashboard option `cookieSessionMaxAge` to keep user logged in across browser sessions ([#2366](#2366)) ([9ea95fc](9ea95fc))
* Blank screen shown if server is unreachable; unsupported pages are accessible via direct URLs ([#2363](#2363)) ([9855258](9855258))
* Dashboard may display blank page when selecting an app after login ([#2375](#2375)) ([f399b91](f399b91))
* Data browser dialog "No data to display" may be outside of visible area in Safari browser ([#2387](#2387)) ([52bba62](52bba62))
* Internal error message on login with missing credential ([#2370](#2370)) ([9a6a31f](9a6a31f))
* Navigation to page fails if user re-login is required ([#2369](#2369)) ([0db6f55](0db6f55))
* Screen goes blank when trying to add column of type `Object` or `GeoPoint` ([#2384](#2384)) ([0886386](0886386))
* Text selection not visible in modal dialog header ([#2340](#2340)) ([fb0e79c](fb0e79c))

### Features

* Add export all rows of a class and export in JSON format ([#2361](#2361)) ([9eb36a1](9eb36a1))
* Add schema export ([#2362](#2362)) ([33df049](33df049))
* remove limitation to refresh Cloud Jobs list only after 30 seconds ([#2332](#2332)) ([ad1132f](ad1132f))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label May 1, 2023
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request May 5, 2023
* source: (41 commits)
  chore(release): 5.1.0 [skip ci]
  chore(release): 5.1.0-beta.2 [skip ci]
  ci: Skip unnecessary builds (parse-community#2389)
  refactor: Upgrade various dependencies (parse-community#2388)
  chore(release): 5.1.0-alpha.10 [skip ci]
  fix: Data browser dialog "No data to display" may be outside of visible area in Safari browser (parse-community#2387)
  chore(release): 5.1.0-alpha.9 [skip ci]
  fix: Screen goes blank when trying to add column of type `Object` or `GeoPoint` (parse-community#2384)
  refactor: Bump http-cache-semantics from 4.1.0 to 4.1.1 (parse-community#2381)
  chore(release): 5.1.0-alpha.8 [skip ci]
  fix: Internal error message on login with missing credential (parse-community#2370)
  refactor: Remove warnings in Docker build (parse-community#2350)
  ci: Restyle preview html (parse-community#2377)
  chore(release): 5.1.0-alpha.7 [skip ci]
  fix: Dashboard may display blank page when selecting an app after login (parse-community#2375)
  ci: Add deployment preview to pull requests via Uffizzi integration (parse-community#2364)
  chore(release): 5.1.0-alpha.6 [skip ci]
  fix: Navigation to page fails if user re-login is required (parse-community#2369)
  refactor: Bump ua-parser-js from 0.7.28 to 0.7.33 (parse-community#2372)
  chore(release): 5.1.0-alpha.5 [skip ci]
  ...

# Conflicts:
#	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging in without a password throws syntax error
3 participants