Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add lint and prettier #2492

Merged
merged 6 commits into from
Jul 4, 2023
Merged

refactor: Add lint and prettier #2492

merged 6 commits into from
Jul 4, 2023

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jul 3, 2023 •
edited
Loading

New Pull Request Checklist

Issue Description

Closes: #2467

Approach

  • Add husky pre-commit hook for prettier and lint
  • Add lint rules
  • Minor refactor to fix lint errors

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title refactor: add lint and prettier refactor: Add lint and prettier Jul 3, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Jul 3, 2023 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza
Copy link
Member Author

mtrezza commented Jul 3, 2023 •
edited
Loading

This is quite a large change across the whole codebase; added prettier and a few lint rules to get rid of code style inconsistencies and this back-and-forth of custom code style adjustments in PRs. The rules are consistent with the rules for parse-server and parse-js-sdk - more or less that is, because they differ slightly from repo to repo.

@parse-community/dashboard please take a look and let know if there's any style change that would not be appropriate for this code type. For example, this codebase contains HTML tags which other repos don't have and prettier or lint replaces the single quotes with double quotes when used in HTML tags.

@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Jul 3, 2023

Uffizzi Ephemeral Environment deployment-29953

⌚ Updated Jul 03, 2023, 01:34 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2492

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza mtrezza requested a review from a team July 3, 2023 11:49
@mtrezza mtrezza merged commit 8e46203 into parse-community:alpha Jul 4, 2023
8 checks passed
@mtrezza mtrezza mentioned this pull request Jul 4, 2023
Merged
3 tasks
@mtrezza mtrezza deleted the refactor-fix-lint branch July 19, 2023 00:05
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-alpha.28

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Aug 27, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Sep 15, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 16, 2023
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Nov 20, 2023
@cycqitianwushuge
Merge branch 'release'
178259d 
* release: (34 commits)
  chore(release): 5.3.0 [skip ci]
  release
  chore(release): 5.3.0-beta.1 [skip ci]
  release
  chore(release): 5.2.0-alpha.28 [skip ci]
  feat: Add security checks page (parse-community#2491)
  refactor: Security upgrade semver from 7.3.7 to 7.5.2 (parse-community#2493)
  refactor: Add lint and prettier (parse-community#2492)
  chore(release): 5.2.0-alpha.27 [skip ci]
  fix: Adding a file when adding a new row in the data browser doesn't show filename (parse-community#2471)
  chore(release): 5.2.0-alpha.26 [skip ci]
  fix: File extension is hidden in file field when editing object in modal dialog in data browser (parse-community#2472)
  chore(release): 5.2.0-alpha.25 [skip ci]
  fix: Incorrect highlight maker position in class list in data browser (parse-community#2490)
  chore(release): 5.2.0-alpha.24 [skip ci]
  feat: Add support for confirmation dialog before script execution in data browser (parse-community#2481)
  chore(release): 5.2.0-alpha.23 [skip ci]
  feat: Add parameter `selectedField` to script payload to determine which object field was selected when script was invoked (parse-community#2483)
  chore(release): 5.2.0-alpha.22 [skip ci]
  feat: Add refresh button to Cloud Config page (parse-community#2480)
  ...

# Conflicts:
#	package-lock.json
#	src/components/LogView/LogViewEntry.react.js
#	src/dashboard/Data/Jobs/Jobs.react.js
#	src/dashboard/Data/Jobs/JobsForm.react.js
#	src/lib/DateUtils.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add linting to repository
2 participants
@mtrezza @parseplatformorg