-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add optional restriction of script execution to certain object fields and values #2488
Conversation
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request!
|
Uffizzi Ephemeral Environment
|
Wow, impressive PR! The two referenced issues are not necessarily related. One could enable a script only on |
Updated the syntax so the full Parse Object is passed through: "validator": (row, field) => row.get(field) > new Date("2025") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you resolve the conflicts? I've merged the lint and prettier PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a short example for this new feature to the README?
Signed-off-by: Daniel <daniel-blyth@live.com.au>
Btw could you see whether the prettier hook works for you? I've added husky to the repo, but not sure whether the git hook is actually working for existing clones of the repo. |
Didn't seem to run for me, perhaps my branch is outdated |
Maybe hooks don't get committed? If I add a hook at least I don't see anything to commit. Anyway, was just a side node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please ament the README to document this feature?
@dblythy Could your take a look at the open questions? This seems almost ready to get merged. |
Uffizzi Ephemeral Environment
|
# [6.0.0-alpha.8](6.0.0-alpha.7...6.0.0-alpha.8) (2024-06-27) ### Features * Add optional restriction of script execution to certain object fields and values ([#2488](#2488)) ([8feac9b](8feac9b))
🎉 This change has been released in version 6.0.0-alpha.8 |
# [6.0.0-beta.2](6.0.0-beta.1...6.0.0-beta.2) (2024-10-07) ### Bug Fixes * Crash after setting filter using context menu and opening filters panel ([#2579](#2579)) ([5a690eb](5a690eb)) * Dashboard not building for Docker platform arm64/v8 ([#2534](#2534)) ([8c4a862](8c4a862)) * Descriptive statistics for number cells in data browser not showing ([#2581](#2581)) ([e146b6f](e146b6f)) * Filter string is erased when changing filter condition ([#2586](#2586)) ([6fa2c8c](6fa2c8c)) * Internal classes `_User`, `_Role`, `_Installation` referenced with pointer don't appear in data browser filter dialog ([#2599](#2599)) ([8239cc8](8239cc8)) ### Features * Add Cloud Config change history to roll back to previous values ([#2554](#2554)) ([a784129](a784129)) * Add data panel to display object related data fetched via Cloud Function ([#2584](#2584)) ([914cc71](914cc71)) * Add optional restriction of script execution to certain object fields and values ([#2488](#2488)) ([8feac9b](8feac9b)) * Add relational filter conditions in data browser ([#2576](#2576)) ([aa5c68d](aa5c68d)) * Add support for Node 22 ([#2603](#2603)) ([3689106](3689106))
🎉 This change has been released in version 6.0.0-beta.2 |
# [6.0.0](5.4.0...6.0.0) (2024-10-07) ### Bug Fixes * App metrics for user and installation counts show dash ([#2528](#2528)) ([850d7b3](850d7b3)) * Class Level Permissions dialog throws error `TypeError: ce.current is null` for newly created class ([#2549](#2549)) ([27ed692](27ed692)) * Config page fails to load ([#2531](#2531)) ([d721b7c](d721b7c)) * Crash after setting filter using context menu and opening filters panel ([#2579](#2579)) ([5a690eb](5a690eb)) * Dashboard crashes if Parse Server Cloud Function script returns object ([#2516](#2516)) ([5de08f8](5de08f8)) * Dashboard not building for Docker platform arm64/v8 ([#2534](#2534)) ([8c4a862](8c4a862)) * Dashboard scrolls when selecting row in data browser ([#2559](#2559)) ([2aa54a5](2aa54a5)) * Data browser redirects to wrong class when changing app ([#2526](#2526)) ([7713f54](7713f54)) * Deleting all code in the JS Console editor fills in the default code ([#2558](#2558)) ([4b830ba](4b830ba)) * Descriptive statistics for number cells in data browser not showing ([#2581](#2581)) ([e146b6f](e146b6f)) * Filter string is erased when changing filter condition ([#2586](#2586)) ([6fa2c8c](6fa2c8c)) * Internal classes `_User`, `_Role`, `_Installation` referenced with pointer don't appear in data browser filter dialog ([#2599](#2599)) ([8239cc8](8239cc8)) * Open pointer in new tab in data browser not working when mount path is not root ([#2527](#2527)) ([2f4081f](2f4081f)) ### Features * Add Cloud Config change history to roll back to previous values ([#2554](#2554)) ([a784129](a784129)) * Add data panel to display object related data fetched via Cloud Function ([#2584](#2584)) ([914cc71](914cc71)) * Add descriptive statistics for number cells in data browser ([#2529](#2529)) ([ead9ec4](ead9ec4)) * Add filter `starts with` in data browser for fields of type Pointer ([#2553](#2553)) ([0b94ab6](0b94ab6)) * Add Node 20 support; remove Node 14, 16 support ([#2532](#2532)) ([578a339](578a339)) * Add Node 20 support; remove Node 14, 16 support ([#2535](#2535)) ([5c90f2d](5c90f2d)) * Add optional restriction of script execution to certain object fields and values ([#2488](#2488)) ([8feac9b](8feac9b)) * Add relational filter conditions in data browser ([#2576](#2576)) ([aa5c68d](aa5c68d)) * Add support for Node 22 ([#2603](#2603)) ([3689106](3689106)) * Execute script for selected rows ([#2508](#2508)) ([5d9901e](5d9901e)) * Select rows in data browser by clicking and dragging mouse cursor over checkboxes ([#2548](#2548)) ([792ba9e](792ba9e)) ### BREAKING CHANGES * Removes support for Node 14 and 16 ([5c90f2d](5c90f2d))
🎉 This change has been released in version 6.0.0 |
# [6.0.0-beta.2](parse-community/parse-dashboard@6.0.0-beta.1...6.0.0-beta.2) (2024-10-07) ### Bug Fixes * Crash after setting filter using context menu and opening filters panel ([parse-community#2579](parse-community#2579)) ([5a690eb](parse-community@5a690eb)) * Dashboard not building for Docker platform arm64/v8 ([parse-community#2534](parse-community#2534)) ([8c4a862](parse-community@8c4a862)) * Descriptive statistics for number cells in data browser not showing ([parse-community#2581](parse-community#2581)) ([e146b6f](parse-community@e146b6f)) * Filter string is erased when changing filter condition ([parse-community#2586](parse-community#2586)) ([6fa2c8c](parse-community@6fa2c8c)) * Internal classes `_User`, `_Role`, `_Installation` referenced with pointer don't appear in data browser filter dialog ([parse-community#2599](parse-community#2599)) ([8239cc8](parse-community@8239cc8)) ### Features * Add Cloud Config change history to roll back to previous values ([parse-community#2554](parse-community#2554)) ([a784129](parse-community@a784129)) * Add data panel to display object related data fetched via Cloud Function ([parse-community#2584](parse-community#2584)) ([914cc71](parse-community@914cc71)) * Add optional restriction of script execution to certain object fields and values ([parse-community#2488](parse-community#2488)) ([8feac9b](parse-community@8feac9b)) * Add relational filter conditions in data browser ([parse-community#2576](parse-community#2576)) ([aa5c68d](parse-community@aa5c68d)) * Add support for Node 22 ([parse-community#2603](parse-community#2603)) ([3689106](parse-community@3689106))
New Pull Request Checklist
Issue Description
Currently,
scripts
show on all fields, and every single value.Closes: #2487
Closes: #2485
Approach
Adds the following script syntax:
If using this syntax, the
script
will only show on a field defined infields
, and it will bedisabled
if thevalidator
returnsfalse
.TODOs before merging