-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Execute script for selected rows #2508
feat: Execute script for selected rows #2508
Conversation
Thanks for opening this pull request!
|
Uffizzi Ephemeral Environment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Just some suggestions:
-
I believe the scripts feature isn't well placed in the "Edit" menu. It also takes too long to find it beneath all these menu items, which slows down the workflow, which is the opposite of what the scripts feature intends to do. Let's dedicate its own new menu "Script > Run script on selected rows..." between "Security" and "Edit".
-
Use "run" instead of "execute" script in the dialog for easier reading:
-
When clicking on the "Run script" button again while the script is running, the counter displayed in the button increases to more than the selected rows; the button should be disabled while the script is running.
-
The cancel button should be enabled to cancel the script execution, or at least close the dialog. Otherwise, if the server does not respond, the user is stuck in the dashboard until the request times out.
I have 2 questions here.
|
@patelmilanun Just a friendly ping in case you haven't seen my previous comment; would be great to get this feature merged. |
Yes, I've seen you message but currently busy in finding a job so once I get some time, I'll again look into it. By the way do you know anyone who can help me in getting a job. |
Sure thing whenever you are ready. If you are experienced with Parse Server you could post your availability in our community forum where we have a jobs section; other than that I could recommend our bounty program (of which this issue is a part of). |
I've made the changes except for 3&4, which we can add later on. I believe releasing the feature as-is provides outweighs the 2 flaws that can be polished out later on. |
# [5.4.0-alpha.2](5.4.0-alpha.1...5.4.0-alpha.2) (2023-12-16) ### Features * Execute script for selected rows ([#2508](#2508)) ([5d9901e](5d9901e))
🎉 This change has been released in version 5.4.0-alpha.2 |
* feat: Add refresh indicator to Cloud Config page (parse-community#2505) * chore(release): 5.3.0-alpha.2 [skip ci] # [5.3.0-alpha.2](parse-community/parse-dashboard@5.3.0-alpha.1...5.3.0-alpha.2) (2023-10-18) ### Features * Add refresh indicator to Cloud Config page ([parse-community#2505](parse-community#2505)) ([a10d1f0](parse-community@a10d1f0)) * release * chore(release): 5.3.0 [skip ci] # [5.3.0](parse-community/parse-dashboard@5.2.0...5.3.0) (2023-11-16) ### Bug Fixes * Adding a file when adding a new row in the data browser doesn't show filename ([parse-community#2471](parse-community#2471)) ([5bbb94e](parse-community@5bbb94e)) * File extension is hidden in file field when editing object in modal dialog in data browser ([parse-community#2472](parse-community#2472)) ([8df4e4d](parse-community@8df4e4d)) * Incorrect highlight maker position in class list in data browser ([parse-community#2490](parse-community#2490)) ([8c28d24](parse-community@8c28d24)) * Pasting location coordinates into field of type `GeoPoint` does not work in data browser ([parse-community#2464](parse-community#2464)) ([a8ce343](parse-community@a8ce343)) * Selecting a saved filter in data browser also highlights other filters with equal names ([parse-community#2466](parse-community#2466)) ([35360fe](parse-community@35360fe)) * Vertical scrollbar in data browser is outside visible area when scrolling horizontally ([parse-community#2457](parse-community#2457)) ([5acac3f](parse-community@5acac3f)) ### Features * Add Cloud Function execution on Parse Object in data browser ([parse-community#2409](parse-community#2409)) ([996ce91](parse-community@996ce91)) * Add parameter `selectedField` to script payload to determine which object field was selected when script was invoked ([parse-community#2483](parse-community#2483)) ([e98d653](parse-community@e98d653)) * Add refresh button to Cloud Config page ([parse-community#2480](parse-community#2480)) ([be212b0](parse-community@be212b0)) * Add security checks page ([parse-community#2491](parse-community#2491)) ([103b9c6](parse-community@103b9c6)) * Add support for confirmation dialog before script execution in data browser ([parse-community#2481](parse-community#2481)) ([64d3913](parse-community@64d3913)) * Add typing with auto-complete to select a filter field in the data browser ([parse-community#2463](parse-community#2463)) ([257f76b](parse-community@257f76b)) * Reopen last opened class when navigating to data browser ([parse-community#2468](parse-community#2468)) ([3d7148e](parse-community@3d7148e)) ### Reverts * fix: Vertical scrollbar in data browser is outside visible area when scrolling horizontally ([parse-community#2457](parse-community#2457)) ([parse-community#2477](parse-community#2477)) ([2f1d84e](parse-community@2f1d84e)) * release * chore(release): 5.4.0-beta.1 [skip ci] # [5.4.0-beta.1](parse-community/parse-dashboard@5.3.0...5.4.0-beta.1) (2023-11-16) ### Features * Add refresh indicator to Cloud Config page ([parse-community#2505](parse-community#2505)) ([a10d1f0](parse-community@a10d1f0)) * refactor: Security upgrade js-beautify from 1.14.6 to 1.14.10 (parse-community#2513) * chore(release): 5.4.0-alpha.1 [skip ci] # [5.4.0-alpha.1](parse-community/parse-dashboard@5.3.0...5.4.0-alpha.1) (2023-12-02) ### Features * Add refresh indicator to Cloud Config page ([parse-community#2505](parse-community#2505)) ([a10d1f0](parse-community@a10d1f0)) * feat: Execute script for selected rows (parse-community#2508) * chore(release): 5.4.0-alpha.2 [skip ci] # [5.4.0-alpha.2](parse-community/parse-dashboard@5.4.0-alpha.1...5.4.0-alpha.2) (2023-12-16) ### Features * Execute script for selected rows ([parse-community#2508](parse-community#2508)) ([5d9901e](parse-community@5d9901e)) * fix: Dashboard crashes if Parse Server Cloud Function script returns object (parse-community#2516) * chore(release): 5.4.0-alpha.3 [skip ci] # [5.4.0-alpha.3](parse-community/parse-dashboard@5.4.0-alpha.2...5.4.0-alpha.3) (2023-12-16) ### Bug Fixes * Dashboard crashes if Parse Server Cloud Function script returns object ([parse-community#2516](parse-community#2516)) ([5de08f8](parse-community@5de08f8)) * fix: Data browser redirects to wrong class when changing app (parse-community#2526) * chore(release): 5.4.0-alpha.4 [skip ci] # [5.4.0-alpha.4](parse-community/parse-dashboard@5.4.0-alpha.3...5.4.0-alpha.4) (2024-02-15) ### Bug Fixes * Data browser redirects to wrong class when changing app ([parse-community#2526](parse-community#2526)) ([7713f54](parse-community@7713f54)) * fix: Open pointer in new tab in data browser not working when mount path is not root (parse-community#2527) * chore(release): 5.4.0-alpha.5 [skip ci] # [5.4.0-alpha.5](parse-community/parse-dashboard@5.4.0-alpha.4...5.4.0-alpha.5) (2024-02-18) ### Bug Fixes * Open pointer in new tab in data browser not working when mount path is not root ([parse-community#2527](parse-community#2527)) ([2f4081f](parse-community@2f4081f)) * fix: App metrics for user and installation counts show dash (parse-community#2528) * chore(release): 5.4.0-alpha.6 [skip ci] # [5.4.0-alpha.6](parse-community/parse-dashboard@5.4.0-alpha.5...5.4.0-alpha.6) (2024-02-26) ### Bug Fixes * App metrics for user and installation counts show dash ([parse-community#2528](parse-community#2528)) ([850d7b3](parse-community@850d7b3)) * feat: Add descriptive statistics for number cells in data browser (parse-community#2529) * chore(release): 5.4.0-alpha.7 [skip ci] # [5.4.0-alpha.7](parse-community/parse-dashboard@5.4.0-alpha.6...5.4.0-alpha.7) (2024-02-26) ### Features * Add descriptive statistics for number cells in data browser ([parse-community#2529](parse-community#2529)) ([ead9ec4](parse-community@ead9ec4)) * fix: Config page fails to load (parse-community#2531) * chore(release): 5.4.0-alpha.8 [skip ci] # [5.4.0-alpha.8](parse-community/parse-dashboard@5.4.0-alpha.7...5.4.0-alpha.8) (2024-02-29) ### Bug Fixes * Config page fails to load ([parse-community#2531](parse-community#2531)) ([d721b7c](parse-community@d721b7c)) * feat: Add Node 20 support; remove Node 14, 16 support (parse-community#2532) * feat: Add Node 20 support; remove Node 14, 16 support (parse-community#2535) BREAKING CHANGE: Removes support for Node 14 and 16 * chore(release): 6.0.0-alpha.1 [skip ci] # [6.0.0-alpha.1](parse-community/parse-dashboard@5.4.0-alpha.8...6.0.0-alpha.1) (2024-03-05) ### Features * Add Node 20 support; remove Node 14, 16 support ([parse-community#2532](parse-community#2532)) ([578a339](parse-community@578a339)) * Add Node 20 support; remove Node 14, 16 support ([parse-community#2535](parse-community#2535)) ([5c90f2d](parse-community@5c90f2d)) ### BREAKING CHANGES * Removes support for Node 14 and 16 ([5c90f2d](5c90f2d)) * refactor: Security upgrade express from 4.18.1 to 4.19.2 (parse-community#2539) * ci: Fix nginx config for preview environment (parse-community#2542) * refactor: Upgrade to npm lockfile version 3 (parse-community#2543) * fix: make cursor pointer for support more icon * fix: more icon cursor pointer * fix: remove console from B4aNotification * feat: add light themed b4aEmptyState * fix: B4aObjectPicker app crash when class exists not * fix: cloudcode empty states * fix: reduce size to remove scrollbar * fix: remove extra space from REST Console top * fix: dark themed dropdown arrow * fix: error modal * feat: add logRocket --------- Co-authored-by: patelmilanun <20059797+patelmilanun@users.noreply.github.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Manuel Trezza <5673677+mtrezza@users.noreply.github.com> Co-authored-by: Parse Platform <90459499+parseplatformorg@users.noreply.github.com> Co-authored-by: Ashish Baravaliya <49753983+AshishBarvaliya@users.noreply.github.com> Co-authored-by: Corey <coreyearleon@icloud.com>
# [6.0.0-beta.1](5.4.0...6.0.0-beta.1) (2024-05-16) ### Bug Fixes * App metrics for user and installation counts show dash ([#2528](#2528)) ([850d7b3](850d7b3)) * Class Level Permissions dialog throws error `TypeError: ce.current is null` for newly created class ([#2549](#2549)) ([27ed692](27ed692)) * Config page fails to load ([#2531](#2531)) ([d721b7c](d721b7c)) * Dashboard crashes if Parse Server Cloud Function script returns object ([#2516](#2516)) ([5de08f8](5de08f8)) * Dashboard scrolls when selecting row in data browser ([#2559](#2559)) ([2aa54a5](2aa54a5)) * Data browser redirects to wrong class when changing app ([#2526](#2526)) ([7713f54](7713f54)) * Deleting all code in the JS Console editor fills in the default code ([#2558](#2558)) ([4b830ba](4b830ba)) * Open pointer in new tab in data browser not working when mount path is not root ([#2527](#2527)) ([2f4081f](2f4081f)) ### Features * Add descriptive statistics for number cells in data browser ([#2529](#2529)) ([ead9ec4](ead9ec4)) * Add filter `starts with` in data browser for fields of type Pointer ([#2553](#2553)) ([0b94ab6](0b94ab6)) * Add Node 20 support; remove Node 14, 16 support ([#2532](#2532)) ([578a339](578a339)) * Add Node 20 support; remove Node 14, 16 support ([#2535](#2535)) ([5c90f2d](5c90f2d)) * Execute script for selected rows ([#2508](#2508)) ([5d9901e](5d9901e)) * Select rows in data browser by clicking and dragging mouse cursor over checkboxes ([#2548](#2548)) ([792ba9e](792ba9e)) ### BREAKING CHANGES * Removes support for Node 14 and 16 ([5c90f2d](5c90f2d))
🎉 This change has been released in version 6.0.0-beta.1 |
# [6.0.0](5.4.0...6.0.0) (2024-10-07) ### Bug Fixes * App metrics for user and installation counts show dash ([#2528](#2528)) ([850d7b3](850d7b3)) * Class Level Permissions dialog throws error `TypeError: ce.current is null` for newly created class ([#2549](#2549)) ([27ed692](27ed692)) * Config page fails to load ([#2531](#2531)) ([d721b7c](d721b7c)) * Crash after setting filter using context menu and opening filters panel ([#2579](#2579)) ([5a690eb](5a690eb)) * Dashboard crashes if Parse Server Cloud Function script returns object ([#2516](#2516)) ([5de08f8](5de08f8)) * Dashboard not building for Docker platform arm64/v8 ([#2534](#2534)) ([8c4a862](8c4a862)) * Dashboard scrolls when selecting row in data browser ([#2559](#2559)) ([2aa54a5](2aa54a5)) * Data browser redirects to wrong class when changing app ([#2526](#2526)) ([7713f54](7713f54)) * Deleting all code in the JS Console editor fills in the default code ([#2558](#2558)) ([4b830ba](4b830ba)) * Descriptive statistics for number cells in data browser not showing ([#2581](#2581)) ([e146b6f](e146b6f)) * Filter string is erased when changing filter condition ([#2586](#2586)) ([6fa2c8c](6fa2c8c)) * Internal classes `_User`, `_Role`, `_Installation` referenced with pointer don't appear in data browser filter dialog ([#2599](#2599)) ([8239cc8](8239cc8)) * Open pointer in new tab in data browser not working when mount path is not root ([#2527](#2527)) ([2f4081f](2f4081f)) ### Features * Add Cloud Config change history to roll back to previous values ([#2554](#2554)) ([a784129](a784129)) * Add data panel to display object related data fetched via Cloud Function ([#2584](#2584)) ([914cc71](914cc71)) * Add descriptive statistics for number cells in data browser ([#2529](#2529)) ([ead9ec4](ead9ec4)) * Add filter `starts with` in data browser for fields of type Pointer ([#2553](#2553)) ([0b94ab6](0b94ab6)) * Add Node 20 support; remove Node 14, 16 support ([#2532](#2532)) ([578a339](578a339)) * Add Node 20 support; remove Node 14, 16 support ([#2535](#2535)) ([5c90f2d](5c90f2d)) * Add optional restriction of script execution to certain object fields and values ([#2488](#2488)) ([8feac9b](8feac9b)) * Add relational filter conditions in data browser ([#2576](#2576)) ([aa5c68d](aa5c68d)) * Add support for Node 22 ([#2603](#2603)) ([3689106](3689106)) * Execute script for selected rows ([#2508](#2508)) ([5d9901e](5d9901e)) * Select rows in data browser by clicking and dragging mouse cursor over checkboxes ([#2548](#2548)) ([792ba9e](792ba9e)) ### BREAKING CHANGES * Removes support for Node 14 and 16 ([5c90f2d](5c90f2d))
🎉 This change has been released in version 6.0.0 |
New Pull Request Checklist
Issue Description
Currently we can't execute a script for selected rows directly and we have to execute it row by row manually.
Closes: #2497
Approach
Added an option in menu with other mass selection action. With this after selection of rows, user can select a script from dialog to execute on those selected rows.
TODOs before merging
NA