Fix #983 verify the whole array to check Parse.Objects into generic objects

[dannywolfmx]

Recursive function to deal with nested objects and check if some children is a Parse.Object type

[dplewis]

Can you post a screenshot?

[dannywolfmx]

Hi sure.

"Producto is a parse object"

Before

And this is my solution

The problem with the actual dashboard is when you try to edit the cell, and the dashboard overwrite the parse server object keeping only the id and losing the reference

[dplewis]

@dannywolfmx Thanks for starting this PR. There are two parts to this issue, displaying and editing.

This PR handles displaying properly.

There is an error with editing an array of array of objects.

testObject.set('arrayField', [[object]])

It stores correctly in the database as [[ '__type': 'Pointer' ...]] but if you edit it will save the full object.

https://github.com/parse-community/parse-dashboard/blob/master/src/dashboard/Data/Browser/BrowserTable.react.js#L204

[dannywolfmx]

Interesting, let's me check the PR to solve the issues.

[dplewis]

I added some nits make sure you pull it down

[dplewis]

@dannywolfmx Can we get this one in? For the editing you can use similar recursion.

[dplewis]

@dannywolfmx @masonlee Can you guys test this out? I added a fix for editing

[acinader]

@dplewis with the returns and the recursive call in the middle of the larger big if, its hard to follow.

if you agree, pull detect out of the if into its own func?

[acinader]

can you pull this function out so its not in the middle of this huge if/else?

[acinader]

same?

[dannywolfmx]

Hi guys, sorry for being late.

Unfortunately I had to work on other projects so I could not devote much time to review this code.

I hope this weekend to be able to finish fixing the bug commented by @dplewis.

It is correct @acinader, it is better to move that block of code out of the if / else so that it can be reused.

I Have a question, Wouldn't it be better to allow the developers to place comments so that other users understand better than the code does?, I find it complex understanding that makes each module to be able to locate the bug.

[dplewis]

@dannywolfmx I went ahead and fixed the bug I mentioned. Just need another set of eyes for testing.

Wouldn't it be better to allow the developers to place comments so that other users understand better than the code does?

Can you elaborate?

[acinader]

@dannywolfmx there are no comments in that file, but there are in others.

definitely feel free to comment the code!

[dannywolfmx]

@dplewis Ok, I'll review it this weekend

[acinader]

Ugh, sorry for serial picking instead of concurrent picking, but can you rename the function please.

we've already detected that it is an array. flattenArray?

And what if the values are date? boolean? etc. is that ok? or do we need another level of factoring here 1. process array 2. process values 3. populate the cell.

here we have 2 levels instead of 3....

[dannywolfmx]

mmm, @acinader you are right. If the user makes an array date types, it will be processed by the "JSON.stringify" and not by the dateStringUTC.

[dannywolfmx]

We Could separate that great block of if/else in another function (setContent or setValue), this way would be easier to do the same thing that does "detectArray " but including all types

[dplewis]

This is how dates are currently handled (with the fixes)

Before Edit (From Database)

"arrayTest": [
        [
            {
                "__type": "Pointer",
                "className": "TestObject",
                "objectId": "agBGsAr7uf"
            }
        ],
        {
            "$date": "2019-04-02T20:07:33.057Z"
        },
        [
            {
                "__type": "Date",
                "iso": "2019-04-02T20:07:33.057Z"
            }
        ]
    ],

After Edit

"arrayTest": [
        [
            {
                "__type": "Pointer",
                "className": "TestObject",
                "objectId": "agBGsAr7uf"
            }
        ],
        {
            "$date": "2019-04-02T20:07:33.057Z"
        },
        [
            {
                "__type": "Date",
                "iso": "2019-04-02T20:07:33.057Z"
            }
        ]
    ],

If you refresh it goes back to how it looked in before edit (note the data in the database is the same even though they look different for view / edit.

[ghost]

Danger run resulted in 1 fail; to find out more, see the checks page.

Generated by 🚫 dangerJS

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dplewis]

Closing via #1223

@dannywolfmx Thanks for getting started on this!